apksig/apksigner crashes on Java 9 due to use of private APIs which are no longer accessible in Java 9 [37137869]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Mar 7, 2017 08:26PM

apksig library's (and thus apksigner's) v1 scheme signature signing and verification code uses Oracle's private PKCS #7 CMS and ASN.1 API (sun.security.*) which is no longer accessible in Java 9 runtime, leading to exceptions such as:

Exception in thread "main" java.lang.IllegalAccessError: class com.android.apksig.internal.apk.v1.V1SchemeVerifier$Signer (in unnamed module @0x7921b0a2) cannot access class sun.security.pkcs.PKCS7 (in module java.base) because module java.base does not export sun.security.pkcs to unnamed module @0x7921b0a2
at com.android.apksig.internal.apk.v1.V1SchemeVerifier$Signer.verifySigBlockAgainstSigFile(V1SchemeVerifier.java:416)
at com.android.apksig.internal.apk.v1.V1SchemeVerifier$Signers.verify(V1SchemeVerifier.java:254)
at com.android.apksig.internal.apk.v1.V1SchemeVerifier$Signers.access$100(V1SchemeVerifier.java:141)
at com.android.apksig.internal.apk.v1.V1SchemeVerifier.verify(V1SchemeVerifier.java:101)
at com.android.apksig.ApkVerifier.verify(ApkVerifier.java:166)
at com.android.apksig.ApkVerifier.verify(ApkVerifier.java:103)
at com.android.apksigner.ApkSignerTool.verify(ApkSignerTool.java:374)
at com.android.apksigner.ApkSignerTool.main(ApkSignerTool.java:96)

Comments

kl...@google.com <kl...@google.com> #2Mar 7, 2017 08:28PM

These changes would be really nice! Being able to change the text colour is really important as it now doesn't match the rest of our app either.

Stack overflow posting -

http://stackoverflow.com/questions/32533069/how-to-change-a-title-color-in-chrome-custom-tabs

ap...@google.com <ap...@google.com> #3May 4, 2017 03:10PM

Changing text color and the overflow icon color is important to us too! Awesome work on the feature though.

to...@google.com <to...@google.com> #4May 10, 2017 04:07PM

The ability of customize the status bar color is very important!

to...@google.com <to...@google.com> #5May 10, 2017 04:20PM

It is in the essence of a "custom" UI component to have a custom color. Please add this feature!

to...@google.com <to...@google.com> #6May 10, 2017 04:31PM

I have noted that the status bar automatically generated from the toolbar color is a bit darker than needed. The status bar color of the chrome activity is different to the one of the rest of my app. It doesn't strictly follow Material guidelines.

kl...@google.com <kl...@google.com> #7May 10, 2017 04:32PM

The same issue I met. And is there a way to customize the title? using my own title rather than the url's. Thanks

to...@google.com <to...@google.com> #8May 23, 2017 06:32PM

Reassigned to to...@google.com.

Would very appreciate this enhancement!

to...@google.com <to...@google.com> #9May 23, 2017 06:34PM

I'd love to have the possibility to change title text color, I'll be a very important graphic consistency inside my app

kl...@google.com <kl...@google.com> #10May 23, 2017 07:18PM

Voting +1 for this feature.

to...@google.com <to...@google.com> #11May 23, 2017 07:33PM

Reassigned to kl...@google.com.

It has been more than a year. Please add this!

to...@google.com <to...@google.com> #12May 24, 2017 01:35PM

[Comment deleted]

to...@google.com <to...@google.com> #13May 24, 2017 09:39PM

It will certainly be a nice feature and have a nice title for the chrome tab. Please fix this.

ap...@google.com <ap...@google.com> #14May 26, 2017 12:09PM

Customize the status bar color is a real need. Voting +1

to...@google.com <to...@google.com> #15May 26, 2017 12:10PM

Yes, it's needed definitely. Please!! Voting+1.

kl...@google.com <kl...@google.com> #16May 26, 2017 04:13PM

Any date to the release of this feature? Working with VectorDrawables is awesome and let us have an IconKit but this little impediment make it not perfect

ap...@google.com <ap...@google.com> #17Jun 26, 2017 10:18PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #18Jun 29, 2017 04:56PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #19Jun 29, 2017 06:03PM

voting +1 for this feature

ap...@google.com <ap...@google.com> #20Jun 29, 2017 06:06PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #21Jun 29, 2017 10:30PM

Voting +1 for this feature.

to...@google.com <to...@google.com> #22Jun 30, 2017 01:07PM

+1 from me. I really need this feature.

ap...@google.com <ap...@google.com> #23Jul 20, 2017 12:39AM

+1 from me. I've to fallback my implementation to webview because of this graphic inconsistency.

ap...@google.com <ap...@google.com> #24Aug 1, 2017 09:39PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #25Aug 7, 2017 07:37PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #26Aug 9, 2017 04:24PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #27Aug 9, 2017 09:28PM

Not being able to set a proper dark or light statusbar/toolbar icon color is breaking our app color design very bad.

+1 for this feature.

ap...@google.com <ap...@google.com> #28Aug 9, 2017 09:29PM

Voting +1 for this feature.

ap...@google.com <ap...@google.com> #29Aug 14, 2017 03:55PM

Estoy de acuerdo con este comentario, es molesto cuando el diseñador te levanta la mano porque no le convence el contraste de los colores y te es imposible responder con fundamento y suplir los criterios. Sería genial poder personalizar más esta sección.

kl...@google.com <kl...@google.com> #30Aug 14, 2017 03:59PM

This has been an issue for 6 years now. Why isn't Google dealing with it? If I'm to use Custom Tabs, I need to be able to change the toolbar text and color at will.

kl...@google.com <kl...@google.com> #31Oct 3, 2017 04:47PM

Status: Assigned (reopened)

ช่วยแก้ไข browser ให้ผมหน่อยครับ

kl...@google.com <kl...@google.com> #32Oct 3, 2017 04:50PM

We're still waiting for apksig library release on jCenter (

https://bintray.com/android/android-tools/com.android.tools.build.apksig). This is normally released whenever Android Plugin for Gradle is released.

kl...@google.com <kl...@google.com> Oct 3, 2017 11:44PM

Accepted by kl...@google.com.

su...@insightauctions.org <su...@insightauctions.org> #33Nov 5, 2017 09:49AM

So what do you guys think?

kl...@google.com <kl...@google.com> #34Nov 6, 2017 05:07PM

About what?

kl...@google.com <kl...@google.com> #35Nov 9, 2017 06:24PM

Marked as fixed.

The changes in apksig library have been publicly released as apksig 3.0.0 in

https://maven.google.com. Apparently, Android Plugin for Gradle (and thus apksig) are now released via this repository instead of via jCenter.

se...@gmail.com <se...@gmail.com> #36Jan 24, 2019 02:51PM

esradgn114@gmail.com

icon.png

1.4 KB

View

Download

google_privacy_policy_tr.pdf

386 KB

View

Download

Issue 37137869

Description

Issue summary

Comments

kl...@google.com <kl...@google.com> #2Mar 7, 2017 08:28PM

ap...@google.com <ap...@google.com> #3May 4, 2017 03:10PM

to...@google.com <to...@google.com> #4May 10, 2017 04:07PM

to...@google.com <to...@google.com> #5May 10, 2017 04:20PM

to...@google.com <to...@google.com> #6May 10, 2017 04:31PM

kl...@google.com <kl...@google.com> #7May 10, 2017 04:32PM

to...@google.com <to...@google.com> #8May 23, 2017 06:32PM

to...@google.com <to...@google.com> #9May 23, 2017 06:34PM

kl...@google.com <kl...@google.com> #10May 23, 2017 07:18PM

to...@google.com <to...@google.com> #11May 23, 2017 07:33PM

to...@google.com <to...@google.com> #12May 24, 2017 01:35PM

to...@google.com <to...@google.com> #13May 24, 2017 09:39PM

ap...@google.com <ap...@google.com> #14May 26, 2017 12:09PM

to...@google.com <to...@google.com> #15May 26, 2017 12:10PM

kl...@google.com <kl...@google.com> #16May 26, 2017 04:13PM

ap...@google.com <ap...@google.com> #17Jun 26, 2017 10:18PM

ap...@google.com <ap...@google.com> #18Jun 29, 2017 04:56PM

ap...@google.com <ap...@google.com> #19Jun 29, 2017 06:03PM

ap...@google.com <ap...@google.com> #20Jun 29, 2017 06:06PM

ap...@google.com <ap...@google.com> #21Jun 29, 2017 10:30PM

to...@google.com <to...@google.com> #22Jun 30, 2017 01:07PM

ap...@google.com <ap...@google.com> #23Jul 20, 2017 12:39AM

ap...@google.com <ap...@google.com> #24Aug 1, 2017 09:39PM

ap...@google.com <ap...@google.com> #25Aug 7, 2017 07:37PM

ap...@google.com <ap...@google.com> #26Aug 9, 2017 04:24PM

ap...@google.com <ap...@google.com> #27Aug 9, 2017 09:28PM

ap...@google.com <ap...@google.com> #28Aug 9, 2017 09:29PM

ap...@google.com <ap...@google.com> #29Aug 14, 2017 03:55PM

kl...@google.com <kl...@google.com> #30Aug 14, 2017 03:59PM

kl...@google.com <kl...@google.com> #31Oct 3, 2017 04:47PM

kl...@google.com <kl...@google.com> #32Oct 3, 2017 04:50PM

kl...@google.com <kl...@google.com> Oct 3, 2017 11:44PM

su...@insightauctions.org <su...@insightauctions.org> #33Nov 5, 2017 09:49AM

kl...@google.com <kl...@google.com> #34Nov 6, 2017 05:07PM

kl...@google.com <kl...@google.com> #35Nov 9, 2017 06:24PM

se...@gmail.com <se...@gmail.com> #36Jan 24, 2019 02:51PM

Add comment

Issue metadata