Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
jb...@google.com <jb...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
navigation-lint-common
hosts test helpers that generatesTestFile
.However, b/368070326 . Instead, it should be in test-specific source sets.
TestFile
is for test only and should not reside in production code. It leads toWe should refactor lint-common code into a new structure with common and common-test submodules
This was done in these CLs aosp/3284996 . But this fix is blocked by recent bytecode migration in ag/29027860 . During migration, the existing path workaround , so this new path breaks presubmit. Thread for context.
"navigation:navigation-lint-common"
was hardcoded into aWhile waiting for an updated workaround or a patch from lint infra, we should in the meantime copy paste
TestFile
related code into each lint test artifact so that we restore lint in the mean time.