Remove TestFile reference from production lint [371463741]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Oct 4, 2024 02:40AM

navigation-lint-common hosts test helpers that generates TestFile.

However, TestFile is for test only and should not reside in production code. It leads to b/368070326. Instead, it should be in test-specific source sets.

We should refactor lint-common code into a new structure with common and common-test submodules

androidx.navigation:navigation-lint {
     common
     common-test
}

This was done in these CLs aosp/3284996. But this fix is blocked by recent bytecode migration in ag/29027860. During migration, the existing path "navigation:navigation-lint-common" was hardcoded into a workaround, so this new path breaks presubmit. Thread for context.

While waiting for an updated workaround or a patch from lint infra, we should in the meantime copy paste TestFile related code into each lint test artifact so that we restore lint in the mean time.

Comments

ap...@google.com <ap...@google.com> #2Oct 9, 2024 04:56AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jb...@google.com <jb...@google.com> #3Oct 11, 2024 12:22AM

Marked as fixed.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Issue 371463741

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Oct 9, 2024 04:56AM

jb...@google.com <jb...@google.com> #3Oct 11, 2024 12:22AM

Add comment

Issue metadata