Status Update
Comments
ma...@google.com <ma...@google.com> #2
Unfortunately bpgp cannot use wire because of the models in com.google.testing.platform:core-proto
that use protobuf
.
Would repackaging be possible if this is used because of that library? We'd have to change the references to that library as well. Am I correct? If yes, would you suggest the best way to proceed?
au...@google.com <au...@google.com> #3
The issue at and is that I bumped protobuf-java dependency for benchmark-baseline-profile-gradle-plugin
and it started crashing all of your tests as AGP was using a method that has been removed from 3.x to 4.x
See
It sounds like we need to fix com.google.testing.platform:core-proto
ma...@google.com <ma...@google.com> #4
Yuki, can we update com.google.testing.platform:core-proto
to use version protobuf 4.28.2
(aosp/3290946)?
ma...@google.com <ma...@google.com> #5
I created a task here
Description
In the process of upgrading protobuf library in androidx then b/371158364 )
:benchmark:benchmark-baseline-profile-gradle-plugin:test
starts crashing due to us upgrading protobuf under AGP plugin (This means that
benchmark-baseline-profile-gradle-plugin
usage forces clients to be in a tricky place where if they to baseline plugin with a new protobuf dependency, then their AGP would crash as well.We either want to move to jarjaring/repackaging this dependency or move to a different runtime (like wire) for reading protobufs.