Fixed
Status Update
Comments
kf...@gmail.com <kf...@gmail.com> #2
Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:
<transition xmlns:android="http://schemas.android.com/apk/res/android " >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="http://schemas.android.com/apk/res/android "
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
<transition xmlns:android="
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
al...@google.com <al...@google.com> #3
Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)
al...@google.com <al...@google.com> #4
al...@google.com <al...@google.com> #5
Next steps:
- Move
core
back to alpha - Merge aosp/3294272
kf...@gmail.com <kf...@gmail.com> #6
Thanks, is there anything else I can do to help now?
al...@google.com <al...@google.com> #7
No, we're all set. The CL has been merged and we'll credit you in the release notes. Thanks!
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Kamal Faraj <
Link:
Add mutability flag to TaskStackBuilder
Expand for full commit details
Add mutability flag to TaskStackBuilder
Relnote: Added mutability flag to TaskStackBuilder
Fixes: 371534781
Test: ./gradlew core:core:assemble
Change-Id: Ife0ec30e6c08d6ed56781cdb58a722a6c1f6b6c1
Signed-off-by: Kamal Faraj <kfaraj.dev@gmail.com>
Files:
- M
core/core/api/current.txt
- M
core/core/api/restricted_current.txt
- M
core/core/src/main/java/androidx/core/app/PendingIntentCompat.java
- M
core/core/src/main/java/androidx/core/app/TaskStackBuilder.java
Hash: 6458efe5d178ea600cd4620b7acfbcc0c380c9fd
Date: Sun Oct 06 18:23:47 2024
pr...@google.com <pr...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.core:core:1.16.0-alpha01
Description
Version used: 1.13.1
Devices/Android versions reproduced on: N/A
This is a feature request to add mutability flag to TaskStackBuilder.
The implementation should be consistent with PendingIntentCompat and provide a variant of getPendingIntent that takes an additional isMutable parameter.