Status Update
Comments
ma...@google.com <ma...@google.com> #2
Could you add the portion of your build.gradle where you specify the GMD configuration? It could be the name you assigned to the device.
pr...@gmail.com <pr...@gmail.com> #3
Is it mandatory for baseline profiles to run on GMD and not on physical devices/emulators?
The bug I reported is about collectDemoNonMinifiedReleaseBaselineProfile
failing because non-GMD device names have spaces in their name.
and collectDemoNonMinifiedReleaseBaselineProfile
considers space as an illegal character.
In the above case, the emulator name is Pixel_6(AVD) - 13
Regarding
could you add the portion of your build.gradle where you specify the GMD configuration?
We don't have that portion because we want to run on physical device / emulator.
ma...@google.com <ma...@google.com> #4
Got it, lemme double check what's going on in the Collect task.
In the meanwhile it should unblock you changing the name of your AVD.
ma...@google.com <ma...@google.com> #5
Could you please also add the full stacktrace? You can get it adding the --stacktrace
option to the gradle command.
cl...@gmail.com <cl...@gmail.com> #6
Edit - This was using baseline profile 1.3.2*
cl...@gmail.com <cl...@gmail.com> #7
ma...@google.com <ma...@google.com> #8
Interesting, it might be a change i did to support ftl. Do you mind testing with 1.3.2 and using the --stacktrace
option reporting here the full crash stacktrace?
cl...@gmail.com <cl...@gmail.com> #9
Sorry for the wait. Attached is the full output of .\gradlew :app:generateReleaseBaselineProfile --stacktrace
.
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Albano <
Link:
Fixed java uri parsing crashing on non uri safe string
Expand for full commit details
Fixed java uri parsing crashing on non uri safe string
The CollectBaselineProfileTask tries to parse the content of the
TestResultProto results for reported files via Uri#parse, but these
might not be parsable strings.
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 371642809
Relnote: "Fixed CollectBaselineProfileTask when AVD device has spaces in it"
Change-Id: Ia0225358081e895d1be20582f97130fad2f06c84
Files:
- M
benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
- M
benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
- M
benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt
Hash: 32d0fb9b82ac37fa7f6d2c8095807aa652ed0c97
Date: Wed Oct 09 14:45:32 2024
ma...@google.com <ma...@google.com> #11
This has been fixed and will be part of 1.3.3 and 1.4.0-alpha03.
Thanks.
cl...@gmail.com <cl...@gmail.com> #12
Thank you!
na...@google.com <na...@google.com> #13
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.3
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.4.0-alpha03
cl...@gmail.com <cl...@gmail.com> #14
Just tested 1.3.3 on both of my affected projects and everything works as expected. Thank you!
Description
FAILURE: Build failed with an exception.
index 161 is space after (AVD) in the above path
Component used: BaselineProfile Version used: 1.3.2 and 1.4.0-alpha02 Devices/Android versions reproduced on: Pixel 6 API 33
You can use this project github.com/android/nowinandroid
and remove
in benchmarks:build.gradle.kts
And run in an emulator which is created locally. Emulator path has spaces in it by default