Execution failed for task ':benchmarks:collectDemoNonMinifiedReleaseBaselineProfile'. [371642809]

Fixed

Bug

Status Update

No update yet.

Description

pr...@gmail.com

created issue #1

Oct 5, 2024 09:49AM

FAILURE: Build failed with an exception.

What went wrong: Execution failed for task ':benchmarks:collectDemoNonMinifiedReleaseBaselineProfile'.

Illegal character in path at index 161: /Users/prudhvi/AndroidStudioProjects/nowinandroid/benchmarks/build/outputs/connected_android_test_additional_output/demoNonMinifiedRelease/connected/Pixel_6(AVD) - 13/StartupBaselineProfile_generate-startup-prof-2024-10-05-09-40-33.txt

index 161 is space after (AVD) in the above path

Component used: BaselineProfile Version used: 1.3.2 and 1.4.0-alpha02 Devices/Android versions reproduced on: Pixel 6 API 33

You can use this project github.com/android/nowinandroid

and remove

baselineProfile {
    // This specifies the managed devices to use that you run the tests on.
    managedDevices.clear()
    managedDevices += "pixel6Api33"

    // Don't use a connected device but rely on a GMD for consistency between local and CI builds.
    useConnectedDevices = false

}

in benchmarks:build.gradle.kts

And run in an emulator which is created locally. Emulator path has spaces in it by default

Comments

ma...@google.com <ma...@google.com> #2Oct 8, 2024 10:18PM

Reassigned to ma...@google.com.

Yigit, do you have time to fix it?

reemission of the same liveData is racy

Message last modified on Oct 8, 2024 10:24PM

pr...@gmail.com <pr...@gmail.com> #3Oct 9, 2024 08:26AM

yea i'll take it.

ma...@google.com <ma...@google.com> #4Oct 9, 2024 05:03PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ma...@google.com <ma...@google.com> #5Oct 9, 2024 05:05PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

cl...@gmail.com <cl...@gmail.com> #6Oct 9, 2024 06:18PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

Message last modified on Oct 9, 2024 06:27PM

exception.txt

19 KB

View

Download

cl...@gmail.com <cl...@gmail.com> #7Oct 9, 2024 06:54PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

ma...@google.com <ma...@google.com> #8Oct 9, 2024 07:01PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

cl...@gmail.com <cl...@gmail.com> #9Oct 9, 2024 08:04PM

Sorry for the wait. Attached is the full output of .\gradlew :app:generateReleaseBaselineProfile --stacktrace.

Message last modified on Oct 9, 2024 08:04PM

trace.txt

29 KB

View

Download

ap...@google.com <ap...@google.com> #10Oct 10, 2024 12:24AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Albano <maralb@google.com>
Link: https://android-review.googlesource.com/3303196

Fixed java uri parsing crashing on non uri safe string

Expand for full commit details

Fixed java uri parsing crashing on non uri safe string

The CollectBaselineProfileTask tries to parse the content of the
TestResultProto results for reported files via Uri#parse, but these
might not be parsable strings.

Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 371642809
Relnote: "Fixed CollectBaselineProfileTask when AVD device has spaces in it"
Change-Id: Ia0225358081e895d1be20582f97130fad2f06c84

Files:

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt

Hash: 32d0fb9b82ac37fa7f6d2c8095807aa652ed0c97
Date: Wed Oct 09 14:45:32 2024

ma...@google.com <ma...@google.com> #11Oct 10, 2024 07:34PM

Marked as fixed.

This has been fixed and will be part of 1.3.3 and 1.4.0-alpha03.

Thanks.

cl...@gmail.com <cl...@gmail.com> #12Oct 10, 2024 11:56PM

Thank you!

na...@google.com <na...@google.com> #13Oct 16, 2024 05:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.3
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.4.0-alpha03

cl...@gmail.com <cl...@gmail.com> #14Oct 17, 2024 07:02PM

Just tested 1.3.3 on both of my affected projects and everything works as expected. Thank you!