Status Update
Comments
ma...@google.com <ma...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
pr...@gmail.com <pr...@gmail.com> #3
ma...@google.com <ma...@google.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ma...@google.com <ma...@google.com> #5
Could you please also add the full stacktrace? You can get it adding the --stacktrace
option to the gradle command.
cl...@gmail.com <cl...@gmail.com> #6
Edit - This was using baseline profile 1.3.2*
cl...@gmail.com <cl...@gmail.com> #7
ma...@google.com <ma...@google.com> #8
Interesting, it might be a change i did to support ftl. Do you mind testing with 1.3.2 and using the --stacktrace
option reporting here the full crash stacktrace?
cl...@gmail.com <cl...@gmail.com> #9
Sorry for the wait. Attached is the full output of .\gradlew :app:generateReleaseBaselineProfile --stacktrace
.
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Albano <
Link:
Fixed java uri parsing crashing on non uri safe string
Expand for full commit details
Fixed java uri parsing crashing on non uri safe string
The CollectBaselineProfileTask tries to parse the content of the
TestResultProto results for reported files via Uri#parse, but these
might not be parsable strings.
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 371642809
Relnote: "Fixed CollectBaselineProfileTask when AVD device has spaces in it"
Change-Id: Ia0225358081e895d1be20582f97130fad2f06c84
Files:
- M
benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
- M
benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
- M
benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt
Hash: 32d0fb9b82ac37fa7f6d2c8095807aa652ed0c97
Date: Wed Oct 09 14:45:32 2024
ma...@google.com <ma...@google.com> #11
This has been fixed and will be part of 1.3.3 and 1.4.0-alpha03.
Thanks.
cl...@gmail.com <cl...@gmail.com> #12
Thank you!
na...@google.com <na...@google.com> #13
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.3
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.4.0-alpha03
cl...@gmail.com <cl...@gmail.com> #14
Just tested 1.3.3 on both of my affected projects and everything works as expected. Thank you!
Description
FAILURE: Build failed with an exception.
index 161 is space after (AVD) in the above path
Component used: BaselineProfile Version used: 1.3.2 and 1.4.0-alpha02 Devices/Android versions reproduced on: Pixel 6 API 33
You can use this project github.com/android/nowinandroid
and remove
in benchmarks:build.gradle.kts
And run in an emulator which is created locally. Emulator path has spaces in it by default