Execution failed for task ':benchmarks:collectDemoNonMinifiedReleaseBaselineProfile'. [371642809]

Fixed

Bug

Status Update

No update yet.

Description

pr...@gmail.com

created issue #1

Oct 5, 2024 09:49AM

FAILURE: Build failed with an exception.

What went wrong: Execution failed for task ':benchmarks:collectDemoNonMinifiedReleaseBaselineProfile'.

Illegal character in path at index 161: /Users/prudhvi/AndroidStudioProjects/nowinandroid/benchmarks/build/outputs/connected_android_test_additional_output/demoNonMinifiedRelease/connected/Pixel_6(AVD) - 13/StartupBaselineProfile_generate-startup-prof-2024-10-05-09-40-33.txt

index 161 is space after (AVD) in the above path

Component used: BaselineProfile Version used: 1.3.2 and 1.4.0-alpha02 Devices/Android versions reproduced on: Pixel 6 API 33

You can use this project github.com/android/nowinandroid

and remove

baselineProfile {
    // This specifies the managed devices to use that you run the tests on.
    managedDevices.clear()
    managedDevices += "pixel6Api33"

    // Don't use a connected device but rely on a GMD for consistency between local and CI builds.
    useConnectedDevices = false

}

in benchmarks:build.gradle.kts

And run in an emulator which is created locally. Emulator path has spaces in it by default

Comments

ma...@google.com <ma...@google.com> #2Oct 8, 2024 10:18PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

Message last modified on Oct 8, 2024 10:24PM

pr...@gmail.com <pr...@gmail.com> #3Oct 9, 2024 08:26AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ma...@google.com <ma...@google.com> #4Oct 9, 2024 05:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ma...@google.com <ma...@google.com> #5Oct 9, 2024 05:05PM

Could you please also add the full stacktrace? You can get it adding the --stacktrace option to the gradle command.

cl...@gmail.com <cl...@gmail.com> #6Oct 9, 2024 06:18PM

I had the same thing happen but on Windows. It seems like it has a problem with the "\" character.

Edit - This was using baseline profile 1.3.2*

Message last modified on Oct 9, 2024 06:27PM

exception.txt

19 KB

View

Download

cl...@gmail.com <cl...@gmail.com> #7Oct 9, 2024 06:54PM

Just tested again with baseline profile 1.2.4 and it worked as expected

ma...@google.com <ma...@google.com> #8Oct 9, 2024 07:01PM

Interesting, it might be a change i did to support ftl. Do you mind testing with 1.3.2 and using the --stacktrace option reporting here the full crash stacktrace?

cl...@gmail.com <cl...@gmail.com> #9Oct 9, 2024 08:04PM

Sorry for the wait. Attached is the full output of .\gradlew :app:generateReleaseBaselineProfile --stacktrace.

Message last modified on Oct 9, 2024 08:04PM

trace.txt

29 KB

View

Download

ap...@google.com <ap...@google.com> #10Oct 10, 2024 12:24AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Albano <maralb@google.com>
Link: https://android-review.googlesource.com/3303196

Fixed java uri parsing crashing on non uri safe string

Expand for full commit details

Fixed java uri parsing crashing on non uri safe string

The CollectBaselineProfileTask tries to parse the content of the
TestResultProto results for reported files via Uri#parse, but these
might not be parsable strings.

Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 371642809
Relnote: "Fixed CollectBaselineProfileTask when AVD device has spaces in it"
Change-Id: Ia0225358081e895d1be20582f97130fad2f06c84

Files:

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/BaselineProfileProjectSetupRule.kt

Hash: 32d0fb9b82ac37fa7f6d2c8095807aa652ed0c97
Date: Wed Oct 09 14:45:32 2024

ma...@google.com <ma...@google.com> #11Oct 10, 2024 07:34PM

Marked as fixed.

This has been fixed and will be part of 1.3.3 and 1.4.0-alpha03.

Thanks.

cl...@gmail.com <cl...@gmail.com> #12Oct 10, 2024 11:56PM

Thank you!

na...@google.com <na...@google.com> #13Oct 16, 2024 05:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.3
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.4.0-alpha03

cl...@gmail.com <cl...@gmail.com> #14Oct 17, 2024 07:02PM

Just tested 1.3.3 on both of my affected projects and everything works as expected. Thank you!