Navigation obsolete custom lint checks with AGP 8.7 [371926651]

Fixed

Bug

Status Update

No update yet.

Description

ar...@physitrack.com

created issue #1

Oct 7, 2024 11:42AM

Component used: Navigation

Version used: 2.8.2

Android Gradle Plugin 8.7.0

Steps to reproduce:

Have AGP 8.7.0 project with Navigation 2.8.2 library attached
Run Android Lint

Following errors occurs, making the lint task to fail:

../intermediates/lint-cache/lintReportDebug/migrated-jars/androidx.navigation.common.lint.NavigationCommonIssueRegistry-3d526261eadfd16f..jar: Library lint checks out of date;
these checks will be skipped!

Lint found an issue registry (androidx.navigation.common.lint.NavigationCommonIssueRegistry)
which was compiled against an older version of lint
than this one. This is usually fine, but not in this
case; some basic verification shows that the lint
check jar references (for example) the following API
which is no longer valid in this version of lint:
com.android.tools.lint.checks.infrastructure.LintDetectorTest#kotlin(java.lang.String): com.android.tools.lint.checks.infrastructure.TestFile
(Referenced from androidx/navigation/lint/common/LintUtilKt.class)

Therefore, this lint check library is not included
in analysis. This affects the following lint checks:
EmptyNavDeepLink,WrongStartDestinationType

Recompile the checks against the latest version, or if
this is a check bundled with a third-party library, see
if there is a more recent version available.

Version of Lint API this lint check is using is 14.
The Lint API version currently running is 16 (8.7+).
../intermediates/lint-cache/lintReportDebug/migrated-jars/androidx.navigation.compose.lint.NavigationComposeIssueRegistry-0eba33012d8b022c..jar: Library lint checks out of date;
these checks will be skipped!

Lint found an issue registry (androidx.navigation.compose.lint.NavigationComposeIssueRegistry)
which was compiled against an older version of lint
than this one. This is usually fine, but not in this
case; some basic verification shows that the lint
check jar references (for example) the following API
which is no longer valid in this version of lint:
com.android.tools.lint.checks.infrastructure.LintDetectorTest#kotlin(java.lang.String): com.android.tools.lint.checks.infrastructure.TestFile
(Referenced from androidx/navigation/lint/common/LintUtilKt.class)

Therefore, this lint check library is not included
in analysis. This affects the following lint checks:
ComposableDestinationInComposeScope,ComposableNavGraphInComposeScope,UnrememberedGetBackStackEntry,WrongStartDestinationType

Recompile the checks against the latest version, or if
this is a check bundled with a third-party library, see
if there is a more recent version available.

Version of Lint API this lint check is using is 14.
The Lint API version currently running is 16 (8.7+).
../intermediates/lint-cache/lintReportDebug/migrated-jars/androidx.navigation.runtime.lint.NavigationRuntimeIssueRegistry-b42dcf0e5b11d978..jar: Library lint checks out of date;
these checks will be skipped!

Lint found an issue registry (androidx.navigation.runtime.lint.NavigationRuntimeIssueRegistry)
which was compiled against an older version of lint
than this one. This is usually fine, but not in this
case; some basic verification shows that the lint
check jar references (for example) the following API
which is no longer valid in this version of lint:
com.android.tools.lint.checks.infrastructure.LintDetectorTest#kotlin(java.lang.String): com.android.tools.lint.checks.infrastructure.TestFile
(Referenced from androidx/navigation/lint/common/LintUtilKt.class)

Therefore, this lint check library is not included
in analysis. This affects the following lint checks:
DeepLinkInActivityDestination,WrongStartDestinationType,WrongNavigateRouteType

Recompile the checks against the latest version, or if
this is a check bundled with a third-party library, see
if there is a more recent version available.

Version of Lint API this lint check is using is 14.
The Lint API version currently running is 16 (8.7+).
Lint can be extended with "custom checks": additional checks implemented by developers and libraries to for example enforce specific API usages required by a library or a company coding style guideline.

The Lint APIs are not yet stable, so these checks may either cause a performance degradation, or stop working, or provide wrong results.

This warning flags custom lint checks that are found to be using obsolete APIs and will need to be updated to run in the current lint environment.

It may also flag issues found to be using a newer version of the API, meaning that you need to use a newer version of lint (or Android Studio or Gradle plugin etc) to work with these checks.
To suppress this error, use the issue id "ObsoleteLintCustomCheck" as explained in the Suppressing Warnings and Errors section.

Comments

jb...@google.com <jb...@google.com> Oct 7, 2024 03:24PM

Status: Duplicate of

368070326

jb...@google.com <jb...@google.com> #2Oct 11, 2024 12:31AM

Status: New (reopened)

This specific error was fixed as part of https://issuetracker.google.com/368070326 where the TestFile was moved to the proper place. That fixed the lint for all AGP versions < 8.7. There is now a new error for the use of older APIs on 8.7 and since 8.7 is still throwing the same error, even though it is for a different reason now, we will track the progress for fixing that on this bug.

The error when using AGP 8.7 is:


../intermediates/lint-cache/lintReportDebug/migrated-jars/androidx.navigation.common.lint.NavigationCommonIssueRegistry-5daa12651be0734e..jar: Library lint checks out of date;
these checks will be skipped!

Lint found an issue registry (androidx.navigation.common.lint.NavigationCommonIssueRegistry)
which was compiled against an older version of lint
than this one. This is usually fine, but not in this
case; some basic verification shows that the lint
check jar references (for example) the following API
which is no longer valid in this version of lint:
org.jetbrains.kotlin.analysis.api.lifetime.KaDefaultLifetimeTokenProvider#Companion
(Referenced from androidx/navigation/lint/UtilKt.class)

Therefore, this lint check library is not included
in analysis. This affects the following lint checks:
EmptyNavDeepLink,WrongStartDestinationType,MissingSerializableAnnotation,MissingKeepAnnotation

Recompile the checks against the latest version, or if
this is a check bundled with a third-party library, see
if there is a more recent version available.

Version of Lint API this lint check is using is 14.
The Lint API version currently running is 16 (8.7+).
../intermediates/lint-cache/lintReportDebug/migrated-jars/androidx.navigation.compose.lint.NavigationComposeIssueRegistry-598b224f0ce2f9f2..jar: Library lint checks out of date;
these checks will be skipped!

Lint found an issue registry (androidx.navigation.compose.lint.NavigationComposeIssueRegistry)
which was compiled against an older version of lint
than this one. This is usually fine, but not in this
case; some basic verification shows that the lint
check jar references (for example) the following API
which is no longer valid in this version of lint:
org.jetbrains.kotlin.analysis.api.lifetime.KaDefaultLifetimeTokenProvider#Companion
(Referenced from androidx/navigation/lint/UtilKt.class)

Therefore, this lint check library is not included
in analysis. This affects the following lint checks:
ComposableDestinationInComposeScope
ComposableNavGraphInComposeScope
UnrememberedGetBackStackEntry
WrongStartDestinationType
MissingKeepAnnotation
MissingSerializableAnnotation

Recompile the checks against the latest version, or if
this is a check bundled with a third-party library, see
if there is a more recent version available.

Version of Lint API this lint check is using is 14.
The Lint API version currently running is 16 (8.7+).
../intermediates/lint-cache/lintReportDebug/migrated-jars/androidx.navigation.runtime.lint.NavigationRuntimeIssueRegistry-a8fea42aedb9bdb3..jar: Library lint checks out of date;
these checks will be skipped!

Lint found an issue registry (androidx.navigation.runtime.lint.NavigationRuntimeIssueRegistry)
which was compiled against an older version of lint
than this one. This is usually fine, but not in this
case; some basic verification shows that the lint
check jar references (for example) the following API
which is no longer valid in this version of lint:
org.jetbrains.kotlin.analysis.api.lifetime.KaDefaultLifetimeTokenProvider#Companion
(Referenced from androidx/navigation/lint/UtilKt.class)

Therefore, this lint check library is not included
in analysis. This affects the following lint checks:
DeepLinkInActivityDestination,WrongStartDestinationType,WrongNavigateRouteType,MissingKeepAnnotation,MissingSerializableAnnotation

Recompile the checks against the latest version, or if
this is a check bundled with a third-party library, see
if there is a more recent version available.

Version of Lint API this lint check is using is 14.
The Lint API version currently running is 16 (8.7+).

Message last modified on Oct 11, 2024 12:32AM

pa...@wewell.app <pa...@wewell.app> #3Nov 27, 2024 09:09AM

It's possible to avoid the issue by disabling the rule. Trying to add it to baseline does nothing for me.

android {
    lint {
        disable += listOf(
            "ObsoleteLintCustomCheck",
        )
    }
}

ap...@google.com <ap...@google.com> #4Dec 4, 2024 11:05PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3284997

Add common-test submodule

Expand for full commit details

Add common-test submodule 
 
We need this lint test source set for common test utils 
 
Test: existing tests pass 
Bug: 371926651 
Change-Id: I9f04a7fe768fd93dc80f1cca03fe9a4ecb2f4d75

Files:

A navigation/lint/common-test/build.gradle
M settings.gradle

Hash: 846f3638ba1425499329ab94c09a01b21fc1e1dc
Date: Wed Oct 09 22:37:43 2024

ap...@google.com <ap...@google.com> #5Dec 4, 2024 11:05PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3284998

Move lint test utils to common-test module

Expand for full commit details

Move lint test utils to common-test module 
 
Test utils cannot be referenced in production code, so we need to move test utils to test source set. 
 
Test: existing tests pass 
Bug: 371926651 
Change-Id: I9db9b1e53d54492f1000cf45342d08993908ccc1

Files:

M navigation/lint/common-test/src/main/java/androidx/navigation/lint/test/Stubs.kt
A navigation/lint/common-test/src/main/java/androidx/navigation/lint/test/Util.kt
M navigation/lint/common/build.gradle
D navigation/lint/common/src/main/java/androidx/navigation/lint/LintUtil.kt
A navigation/lint/common/src/main/java/androidx/navigation/lint/Util.kt
M navigation/navigation-common-lint/build.gradle
M navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/NavigationCommonIssueRegistry.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/CompatUtil.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingKeepAnnotationDetectorTest.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingSerializableAnnotationDetectorTest.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetectorTest.kt
M navigation/navigation-compose-lint/build.gradle
M navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/NavigationComposeIssueRegistry.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/CompatUtil.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingKeepAnnotationDetectorTest.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingSerializableAnnotationDetectorTest.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/Stubs.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetectorTest.kt
M navigation/navigation-runtime-lint/build.gradle
M navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/NavigationRuntimeIssueRegistry.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/CompatUtil.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingKeepAnnotationDetectorTest.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingSerializableAnnotationDetectorTest.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/Stubs.kt

Hash: c096da78e256c30df77af2b59033c0378adc4e28
Date: Wed Oct 09 22:40:13 2024

ap...@google.com <ap...@google.com> #6Dec 4, 2024 11:05PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3284996

Move navigation-lint-common to submodule within navigation-lint

Expand for full commit details

Move navigation-lint-common to submodule within navigation-lint 
 
This new structure will allow us to create a second submodule `common-test` to house test-specific utils. 
 
Test: existing tests pass 
Bug: 371926651 
Change-Id: I13c07e3ad37ba52f5a0dbef3e2668afd360306b9

Files:

M navigation/lint/common/build.gradle
M navigation/lint/common/src/main/java/androidx/navigation/lint/BaseTypeSafeDestinationMissingAnnotationDetector.kt
M navigation/lint/common/src/main/java/androidx/navigation/lint/BaseWrongStartDestinationTypeDetector.kt
M navigation/lint/common/src/main/java/androidx/navigation/lint/LintUtil.kt
M navigation/lint/common/src/main/java/androidx/navigation/lint/TestStub.kt
M navigation/navigation-common-lint/build.gradle
M navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/TypeSafeDestinationMissingAnnotationDetector.kt
M navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetector.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/CompatUtil.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingKeepAnnotationDetectorTest.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingSerializableAnnotationDetectorTest.kt
M navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetectorTest.kt
M navigation/navigation-compose-lint/build.gradle
M navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/TypeSafeDestinationMissingAnnotationDetector.kt
M navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetector.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/CompatUtil.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingKeepAnnotationDetectorTest.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingSerializableAnnotationDetectorTest.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/Stubs.kt
M navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetectorTest.kt
M navigation/navigation-runtime-lint/build.gradle
M navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/TypeSafeDestinationMissingAnnotationDetector.kt
M navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongNavigateRouteDetector.kt
M navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongPopBackStackRouteDetector.kt
M navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongStartDestinationTypeDetector.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/CompatUtil.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingKeepAnnotationDetectorTest.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingSerializableAnnotationDetectorTest.kt
M navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/Stubs.kt
M settings.gradle

Hash: 23c78e6c3e1c9332b45d68985a6f04c45c4d1929
Date: Thu Sep 26 10:09:05 2024

cl...@google.com <cl...@google.com> #7Dec 4, 2024 11:06PM

Marked as fixed, reassigned to cl...@google.com.

Fixed and available in both navigation 2.8.5 and navigation 2.9.0-alpha04

yc...@gmail.com <yc...@gmail.com> #8Dec 12, 2024 01:37AM

Looks like it's still happening with 2.8.5.

cl...@google.com <cl...@google.com> #9Dec 20, 2024 11:30PM

The agp version also needs to be 8.8.0-rc02 or higher.

Issue 371926651

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> Oct 7, 2024 03:24PM

jb...@google.com <jb...@google.com> #2Oct 11, 2024 12:31AM

pa...@wewell.app <pa...@wewell.app> #3Nov 27, 2024 09:09AM

ap...@google.com <ap...@google.com> #4Dec 4, 2024 11:05PM

ap...@google.com <ap...@google.com> #5Dec 4, 2024 11:05PM

ap...@google.com <ap...@google.com> #6Dec 4, 2024 11:05PM

cl...@google.com <cl...@google.com> #7Dec 4, 2024 11:06PM

yc...@gmail.com <yc...@gmail.com> #8Dec 12, 2024 01:37AM

cl...@google.com <cl...@google.com> #9Dec 20, 2024 11:30PM

Add comment

Issue metadata