Status Update
Comments
jb...@google.com <jb...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
pa...@wewell.app <pa...@wewell.app> #3
ap...@google.com <ap...@google.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <
Link:
Move lint test utils to common-test module
Expand for full commit details
Move lint test utils to common-test module
Test utils cannot be referenced in production code, so we need to move test utils to test source set.
Test: existing tests pass
Bug: 371926651
Change-Id: I9db9b1e53d54492f1000cf45342d08993908ccc1
Files:
- M
navigation/lint/common-test/src/main/java/androidx/navigation/lint/test/Stubs.kt
- A
navigation/lint/common-test/src/main/java/androidx/navigation/lint/test/Util.kt
- M
navigation/lint/common/build.gradle
- D
navigation/lint/common/src/main/java/androidx/navigation/lint/LintUtil.kt
- A
navigation/lint/common/src/main/java/androidx/navigation/lint/Util.kt
- M
navigation/navigation-common-lint/build.gradle
- M
navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/NavigationCommonIssueRegistry.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/CompatUtil.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetectorTest.kt
- M
navigation/navigation-compose-lint/build.gradle
- M
navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/NavigationComposeIssueRegistry.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/CompatUtil.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/Stubs.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetectorTest.kt
- M
navigation/navigation-runtime-lint/build.gradle
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/NavigationRuntimeIssueRegistry.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/CompatUtil.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/Stubs.kt
Hash: c096da78e256c30df77af2b59033c0378adc4e28
Date: Wed Oct 09 22:40:13 2024
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Move navigation-lint-common to submodule within navigation-lint
Expand for full commit details
Move navigation-lint-common to submodule within navigation-lint
This new structure will allow us to create a second submodule `common-test` to house test-specific utils.
Test: existing tests pass
Bug: 371926651
Change-Id: I13c07e3ad37ba52f5a0dbef3e2668afd360306b9
Files:
- M
navigation/lint/common/build.gradle
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/BaseTypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/BaseWrongStartDestinationTypeDetector.kt
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/LintUtil.kt
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/TestStub.kt
- M
navigation/navigation-common-lint/build.gradle
- M
navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/TypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetector.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/CompatUtil.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetectorTest.kt
- M
navigation/navigation-compose-lint/build.gradle
- M
navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/TypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetector.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/CompatUtil.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/Stubs.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetectorTest.kt
- M
navigation/navigation-runtime-lint/build.gradle
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/TypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongNavigateRouteDetector.kt
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongPopBackStackRouteDetector.kt
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongStartDestinationTypeDetector.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/CompatUtil.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/Stubs.kt
- M
settings.gradle
Hash: 23c78e6c3e1c9332b45d68985a6f04c45c4d1929
Date: Thu Sep 26 10:09:05 2024
cl...@google.com <cl...@google.com> #7
Fixed and available in both navigation 2.8.5
and navigation 2.9.0-alpha04
yc...@gmail.com <yc...@gmail.com> #8
Looks like it's still happening with 2.8.5.
cl...@google.com <cl...@google.com> #9
The agp version also needs to be 8.8.0-rc02
or higher.
Description
Component used: Navigation
Version used: 2.8.2
Android Gradle Plugin 8.7.0
Steps to reproduce:
Following errors occurs, making the lint task to fail: