Fixed
Status Update
Comments
jb...@google.com <jb...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
pa...@wewell.app <pa...@wewell.app> #3
since it is already marked as deprecated, we can probably do it by now.
ap...@google.com <ap...@google.com> #4
Opening diff shortly
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Move navigation-lint-common to submodule within navigation-lint
Expand for full commit details
Move navigation-lint-common to submodule within navigation-lint
This new structure will allow us to create a second submodule `common-test` to house test-specific utils.
Test: existing tests pass
Bug: 371926651
Change-Id: I13c07e3ad37ba52f5a0dbef3e2668afd360306b9
Files:
- M
navigation/lint/common/build.gradle
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/BaseTypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/BaseWrongStartDestinationTypeDetector.kt
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/LintUtil.kt
- M
navigation/lint/common/src/main/java/androidx/navigation/lint/TestStub.kt
- M
navigation/navigation-common-lint/build.gradle
- M
navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/TypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetector.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/CompatUtil.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/WrongStartDestinationTypeDetectorTest.kt
- M
navigation/navigation-compose-lint/build.gradle
- M
navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/TypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/navigation-compose-lint/src/main/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetector.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/CompatUtil.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/Stubs.kt
- M
navigation/navigation-compose-lint/src/test/java/androidx/navigation/compose/lint/WrongStartDestinationTypeDetectorTest.kt
- M
navigation/navigation-runtime-lint/build.gradle
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/TypeSafeDestinationMissingAnnotationDetector.kt
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongNavigateRouteDetector.kt
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongPopBackStackRouteDetector.kt
- M
navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/WrongStartDestinationTypeDetector.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/CompatUtil.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingKeepAnnotationDetectorTest.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/MissingSerializableAnnotationDetectorTest.kt
- M
navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/Stubs.kt
- M
settings.gradle
Hash: 23c78e6c3e1c9332b45d68985a6f04c45c4d1929
Date: Thu Sep 26 10:09:05 2024
cl...@google.com <cl...@google.com> #7
Fixed and available in both navigation 2.8.5
and navigation 2.9.0-alpha04
yc...@gmail.com <yc...@gmail.com> #8
Looks like it's still happening with 2.8.5.
cl...@google.com <cl...@google.com> #9
The agp version also needs to be 8.8.0-rc02
or higher.
Description
Component used: Navigation
Version used: 2.8.2
Android Gradle Plugin 8.7.0
Steps to reproduce:
Following errors occurs, making the lint task to fail: