Fixed
Status Update
No update yet.
Comments
os...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Oscar Adame Vázquez <
Link:
Fix animateContentSize Alignment under RTL
Expand for full commit details
Fix animateContentSize Alignment under RTL
SizeModifierNode (under AnimatedContent) was placing its content relative to LayoutDirection after calculating the Alignment, which already takes LayoutDirection into account, effectively undoing the LayoutDirection calculation.
Bug: 372055503
Test: updated AnimationModifierTest
Change-Id: Idae6b6255bb15b0f366b2737e68131f2db733bcb
Files:
- M
compose/animation/animation/src/androidInstrumentedTest/kotlin/androidx/compose/animation/AnimationModifierTest.kt - M
compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt
Hash: 09df7e4ffc326202b9d78641178fb997d47e3ab0
Date: Tue Oct 08 13:16:31 2024
os...@google.com
Thanks for the thorough report, we've identified a fix and we'll try to get the regression fixed on the stable branch.
Description
Jetpack Compose version: 1.7.3
Jetpack Compose component used:
Modifer.animateContentSize()Android Studio Build: #AI-242.21829.142.2421.12409432 (Ladybug | 2024.2.1)
Kotlin version: 2.0.20
I have been using the
ModalNavigationDrawercomponent in a Compose TV app since last year (Compose v1.6.*). However, after upgrading the Compose dependencies to version 1.7.3, I noticed a strange behavior in the open/close animation of the drawer. Upon further investigation, I discovered that the issue only occurs in RTL layout direction, while everything works fine in LTR direction.After comparing the differences with the previous version and modifying the
ModalNavigationDrawercomponent code, I found that the problem lies in theanimateContentSize()modifier within theModalNavigationDrawersource code. It seems to be related to thealignmentargument added to theSizeAnimationModifierNodesince the last Compose version I was using. I foundSteps to Reproduce or Code Sample to Reproduce:
Use
ModalNavigationDrawerin RTL layout direction in a Compose TV application with Compose Animation version 1.7.3. Open and close the drawer to observe the awkward animation behavior.