Awkward animation behavior in ModalNavigationDrawer in Compose TV [372055503]

Fixed

Bug

Status Update

No update yet.

Description

se...@gmail.com

created issue #1

Oct 8, 2024 09:53AM

Jetpack Compose version: 1.7.3

Jetpack Compose component used: Modifer.animateContentSize()

Android Studio Build: #AI-242.21829.142.2421.12409432 (Ladybug | 2024.2.1)

Kotlin version: 2.0.20

I have been using the ModalNavigationDrawer component in a Compose TV app since last year (Compose v1.6.*). However, after upgrading the Compose dependencies to version 1.7.3, I noticed a strange behavior in the open/close animation of the drawer. Upon further investigation, I discovered that the issue only occurs in RTL layout direction, while everything works fine in LTR direction.

After comparing the differences with the previous version and modifying the ModalNavigationDrawer component code, I found that the problem lies in the animateContentSize() modifier within the ModalNavigationDrawer source code. It seems to be related to the alignment argument added to the SizeAnimationModifierNode since the last Compose version I was using. I found this issue and believe it has been present since then.

Steps to Reproduce or Code Sample to Reproduce:

Use ModalNavigationDrawer in RTL layout direction in a Compose TV application with Compose Animation version 1.7.3. Open and close the drawer to observe the awkward animation behavior.

Comments

os...@google.com <os...@google.com> Oct 8, 2024 05:57PM

Reassigned to os...@google.com.

ap...@google.com <ap...@google.com> #2Oct 8, 2024 09:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

os...@google.com <os...@google.com> #3Oct 8, 2024 10:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

os...@google.com <os...@google.com> #4Nov 12, 2024 07:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit c3a06e79cf427aef1cf0ede1bacb463eb89472be
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 /

r.android.com/3156121 but now with
moving to project(":annotation:annotation") in commonMain as due to

https://youtrack.jetbrains.com/issue/KT-62653 we cannot depend on
project in one source set and prebuilt in the other.

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: I7f2a1bddbe79ab5e920cdb01ca6a428950a8c2c3

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M busytown/androidx_multiplatform_mac_host_tests_arm64.sh
M camera/integration-tests/avsynctestapp/build.gradle
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
M test/uiautomator/integration-tests/testapp/build.gradle
M wear/compose/integration-tests/navigation/build.gradle

https://android-review.googlesource.com/3156423

Issue 372055503

Description

Issue summary

Comments

os...@google.com <os...@google.com> Oct 8, 2024 05:57PM

ap...@google.com <ap...@google.com> #2Oct 8, 2024 09:39PM

os...@google.com <os...@google.com> #3Oct 8, 2024 10:29PM

os...@google.com <os...@google.com> #4Nov 12, 2024 07:24PM

Add comment

Issue metadata