Fixed
Status Update
No update yet.
Comments
ke...@google.com
se...@google.com
se...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <
Link:
[M3][BottomSheet] Update BottomSheetScaffold layout to wrap user Modifier along it's root.
Expand for full commit details
[M3][BottomSheet] Update BottomSheetScaffold layout to wrap user Modifier along it's root.
Bug: 372311595
Test: Nested scroll modifier hierarchy testing passes.
RelNote: "Move modifier parameter to the scaffolds root, as documented. This aligns implementation with M2."
Change-Id: I0235ea935c42700a5e0aa5205d0d8a7bc8ffe88e
Files:
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
Hash: 01d48c68c5e4951e5fad65b67e744e6f568e01ad
Date: Wed Nov 06 14:49:01 2024
Description
recent:
androidx.compose.material3:material3:1.3.0
androidx.compose.material:material:1.8.0-alpha02
Why does material3 BottomSheetScaffold pass the modifier parameter to a child Surface element that only wraps the body content of the BottomSheetScaffold, instead of to the parent layout for the entire component?
This differs from the material BottomSheetScaffold behavior which passes the modifier to a Surface wraps the entire parent layout.
Resulted in a tricky migration from material to material3 for this component where we wrap BottomSheetScaffold inside the content body of a parent Scaffold which contains a bottom bar. But with the material3 version of BottomSheetScaffold, the padding from that parent Scaffold now can no longer be passed as a modifier directly to the child material3 BottomSheetScaffold