Fixed
Status Update
No update yet.
Comments
ke...@google.com
se...@google.com
se...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
Description
recent:
androidx.compose.material3:material3:1.3.0
androidx.compose.material:material:1.8.0-alpha02
Why does material3 BottomSheetScaffold pass the modifier parameter to a child Surface element that only wraps the body content of the BottomSheetScaffold, instead of to the parent layout for the entire component?
This differs from the material BottomSheetScaffold behavior which passes the modifier to a Surface wraps the entire parent layout.
Resulted in a tricky migration from material to material3 for this component where we wrap BottomSheetScaffold inside the content body of a parent Scaffold which contains a bottom bar. But with the material3 version of BottomSheetScaffold, the padding from that parent Scaffold now can no longer be passed as a modifier directly to the child material3 BottomSheetScaffold