Benchmarks - Regression between Merge "Fixed user 0 hardcoded in profile installer" into androidx-main and Merge "Add onRectChanged modifier and corresponding callback support to rect tracking" into androidx-main [372757007]

Fixed

Bug

Status Update

No update yet.

Description

pe...@skia-infra-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 12, 2024 03:54AM

Perf Regression (Low) found, matching 9 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Test classes affected:

 androidx.compose.animation.core.benchmark.SpringEstimationBenchmark
 androidx.compose.ui.benchmark.accessibility.TextAccessibilityBenchmark
 androidx.compose.ui.benchmark.focus.ParameterizedFocusBenchmark
 androidx.compose.ui.benchmark.spatial.RectListBenchmark

Test methods affected:

 b04_updateScrollableContainer
 benchmarkCriticallyDamped
 createAccessibilityNodeInfoFromId_singleTextComponent_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromRoot_singleTextComponent_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 createAccessibilityNodeInfoFromRoot_singleTextComponent_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 modifyActiveHierarchy_addRemoveModifiersWithExistingSubtree_100_

Devices affected:

 aosp_mokey
 sargo

API Level:

 API_30_R
 API_31_S
 API_34_U

Comments

pe...@skia-infra-public.iam.gserviceaccount.com <pe...@skia-infra-public.iam.gserviceaccount.com> #2Oct 12, 2024 03:54AM

Perf Regression (High) found, matching 445 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Test classes affected:

 androidx.compose.foundation.benchmark.OverscrollBenchmark
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark
 androidx.compose.foundation.benchmark.lazy.ReuseBenchmark
 androidx.compose.foundation.benchmark.pager.PagerBasicBenchmark
 androidx.compose.foundation.benchmark.text.TextFieldToggleTextBenchmark
 androidx.compose.foundation.benchmark.text.empirical.AllAppsWithInlineContent
 androidx.compose.foundation.benchmark.text.empirical.baselines.AllAppsEmptyLayoutBaselineBaseline
 androidx.compose.foundation.layout.benchmark.DeepRowColumnBenchmark
 androidx.compose.foundation.layout.benchmark.RectsInColumnBenchmark
 androidx.compose.foundation.layout.benchmark.RectsInFlowColumnBenchmark
 androidx.compose.material.benchmark.RadioGroupBenchmark
 androidx.compose.ui.benchmark.ModifiersBenchmark
 androidx.wear.compose.material.benchmark.ButtonBenchmark
 androidx.wear.compose.material.benchmark.ChipBenchmark
 androidx.wear.compose.material.benchmark.SliderBenchmark
 androidx.wear.compose.material.benchmark.StepperBenchmark
 androidx.wear.compose.material.benchmark.ToggleChipBenchmark
 androidx.wear.compose.material3.benchmark.IconBenchmark

Test methods affected:

 component_modifiersOnly_first_layout
 component_twoLayoutNodes_update_layout
 create_button
 first_layout
 first_layout_10_
 fullHoisted_emptyElement_10x_
 fullHoisted_emptyElement_1x_
 fullHoisted_pointerInput_10x_
 fullHoisted_semantics_10x_
 fullReuseHoisted_Modifier_10x_
 fullReuseHoisted_clickableWithRipple_100x_
 fullReuseHoisted_clickable_10x_
 fullReuseHoisted_draggable_10x_
 fullReuseHoisted_drawWithCache_10x_
 fullReuseHoisted_selectable_10x_
 fullReuseHoisted_semantics_100x_
 fullReuseHoisted_semantics_10x_
 fullReuseHoisted_testTag_10x_
 fullReuse_clickableWithRipple_1x_
 fullReuse_indication_10x_
 fullReuse_onFocusEvent_10x_
 fullReuse_scrollable_10x_
 fullReuse_semantics_10x_
 full_clickable_10x_
 full_draggable_10x_
 full_focusRequester_10x_
 full_focusTarget_10x_
 full_onFocusEvent_10x_
 full_pointerInput_10x_
 full_toggleable_10x_
 layout
 layout_10_
 layout_Bitmap_
 layout_depth_1_breadth_3_weight_false_align_true_
 layout_full_page
 layout_length_32_
 recomposeMeasureLayout_size_2_
 reuse_multi_page
 toggleRadio_layout
 toggleRectangleColor_layout_10_

Devices affected:

 aosp_mokey
 sargo

API Level:

 API_30_R
 API_31_S
 API_34_U

lp...@google.com <lp...@google.com> Oct 14, 2024 01:04PM

Reassigned to le...@google.com.

ap...@google.com <ap...@google.com> #3Oct 17, 2024 04:11AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Leland Richardson <lelandr@google.com>
Link: https://android-review.googlesource.com/3309717

Add onRectChanged modifier and corresponding callback support to rect tracking

Expand for full commit details

Add onRectChanged modifier and corresponding callback support to rect tracking

Fixes: 372765423
Fixes: 372757007
Fixes: 372994338

Relnote:"""
Added Modifier.onRectChanged API which is an API that allows one to subscribe to the root/window/screen-relative position and size of a
LayoutNode. The API solves many use cases that the existing onGloballyPositioned modifier does, however it does so with much less
overhead and the API comes with facilities to debounce and throttle the callback per what one's use case demands.
"""

Change-Id: Id28c7c6c52ce3b18c9ac8c83cde48111a312cfc9

Files:

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/layout/OnGlobalRectChangedTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/layout/OnGloballyPositionedTest.kt
A compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/Actual.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/spatial/RectListTest.kt
A compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/spatial/ThrottledCallbacksTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/Expect.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/OnRectChangedModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/MeasureAndLayoutDelegate.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/spatial/RectInfo.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/spatial/RectList.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/spatial/RectManager.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/spatial/ThrottledCallbacks.kt
M compose/ui/ui/src/commonStubsMain/kotlin/androidx/compose/ui/Actual.commonStubs.kt

Hash: ce33454f34929182e1109f6254144d390f27e7c8
Date: Wed Oct 16 13:18:34 2024

pr...@google.com <pr...@google.com> #4Oct 30, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.8.0-alpha05
androidx.compose.ui:ui-android:1.8.0-alpha05
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha05
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha05

Issue 372757007

Description

Issue summary

Comments

pe...@skia-infra-public.iam.gserviceaccount.com <pe...@skia-infra-public.iam.gserviceaccount.com> #2Oct 12, 2024 03:54AM

lp...@google.com <lp...@google.com> Oct 14, 2024 01:04PM

ap...@google.com <ap...@google.com> #3Oct 17, 2024 04:11AM

pr...@google.com <pr...@google.com> #4Oct 30, 2024 05:37PM

Add comment

Issue metadata