`eventFlow` should complete when `Lifecycle` is `DESTROYED` [374043130]

Fixed

Bug

Status Update

No update yet.

Description

mg...@google.com

created issue #1

Oct 17, 2024 10:11AM

Currently, Lifecycle.eventFlow stops sending out new events when the Lifecycle reaches the DESTROYED state. However, the Flow never completes.

Ideally, Lifecycle.eventFlow should complete when the Lifecycle is DESTROYED. This would signal to consumers that they won't receive any new emissions and the flow is terminated.

We found this issue while working on b/370577987, which disallows moving from the DESTROYED state to any other state.

Comments

ap...@google.com <ap...@google.com> #2Oct 17, 2024 05:13PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

mg...@google.com <mg...@google.com> Oct 24, 2024 03:36PM

Marked as fixed.

il...@google.com <il...@google.com> #3Oct 25, 2024 05:28AM

yea i'll take it.

pr...@google.com <pr...@google.com> #4Oct 30, 2024 05:38PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

Issue 374043130

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Oct 17, 2024 05:13PM

mg...@google.com <mg...@google.com> Oct 24, 2024 03:36PM

il...@google.com <il...@google.com> #3Oct 25, 2024 05:28AM

pr...@google.com <pr...@google.com> #4Oct 30, 2024 05:38PM

Add comment

Issue metadata