Nesting providesDefault for a LocalProvider blocks changes from other LocalProviders from being propagated down the line [374263387]

Fixed

Bug

Status Update

No update yet.

Description

hr...@gmail.com

created issue #1

Oct 18, 2024 01:05PM

Jetpack Compose version: 1.7.1

Jetpack Compose component(s) used: ProvidableCompositionLocal and providesDefault

Android Studio Build: Jellyfish 2023.3.1 Patch 2

Kotlin version: 2.0.21

Steps to Reproduce or Code Sample to Reproduce:

Nesting multiple providesDefault for a ProvidableCompositionLocal blocks any changes from other wrapper ProvidableCompositionLocals from being propagated from the root block to the second nested block.

Example:

val LocalValue: ProvidableCompositionLocal<Int> =
    staticCompositionLocalOf { error("No value provided") }

val LocalOtherValue: ProvidableCompositionLocal<Boolean> =
    staticCompositionLocalOf { error("No other value provided") }


@Composable
fun Example() {
    var external by remember { mutableStateOf(false) }

    CompositionLocalProvider(LocalOtherValue provides external) {
        LocalOtherValue.current.also {
            LaunchedEffect(it) { println("Root block other value changed") }
        }
        CompositionLocalProvider(LocalValue providesDefault 1) {
            LocalOtherValue.current.also {
                LaunchedEffect(it) { println("First block other value changed") }
            }
            CompositionLocalProvider(LocalValue providesDefault 1) {
                LocalOtherValue.current.also {
                    LaunchedEffect(it) { println("Second block other value changed") }
                }
            }
        }
    }

    LaunchedEffect(Unit) {
        delay(1000)
        external = !external
    }
}

In this example "Second block other value changed" should get printed twice because LocalOtherValue is expected to change and trigger the LaunchedEffect inside the second block but it does not. It only changes inside the "Root block other value changed" and "First block other value changed" blocks.

As per my understanding providesDefault should only affect LocalValue.

Comments

jo...@google.com <jo...@google.com> Oct 21, 2024 05:25PM

Assigned to je...@google.com.

al...@google.com <al...@google.com> #2Oct 24, 2024 04:43PM

Reassigned to ch...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ch...@google.com <ch...@google.com> #3Oct 24, 2024 05:35PM

Accepted by ch...@google.com.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

sk...@gmail.com <sk...@gmail.com> #4Oct 25, 2024 08:16AM

Comment has been deleted.

Message last modified on Oct 25, 2024 08:16AM

hr...@gmail.com <hr...@gmail.com> #5Oct 25, 2024 08:17AM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ap...@google.com <ap...@google.com> #6Oct 29, 2024 04:44PM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

na...@google.com <na...@google.com> #7Nov 13, 2024 06:19PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!