Assigned

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Oct 18, 2024 08:48PM

Instructions

Apply https://r.android.com/q/topic:%22Kotlin+2.1.0-Beta2%22
Run ./gradlew :room:room-gradle-plugin:test

Expected

No crash

Actual

Crash

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x0000000000001056, pid=3925750, tid=3938596
#
# JRE version: OpenJDK Runtime Environment Android_PDK (17.0.4.1) (build 17.0.4.1+0-11116395)
# Java VM: OpenJDK 64-Bit Server VM Android_PDK (17.0.4.1+0-11116395, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# C  0x0000000000001056
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/room/room-gradle-plugin/hs_err_pid3925750.log
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

https://ci.android.com/builds/pending/P82992532/androidx_host_tests/latest/view/logs%2Fbuild_error.log https://ci.android.com/builds/pending/P82992532/androidx_host_tests/latest/view/new_files%2Froom%2Froom-gradle-plugin%2Fhs_err_pid70924.log

Notes

Able to repro locally

Comments

da...@google.com <da...@google.com> #2Oct 21, 2024 04:57PM

Reassigned to da...@google.com.

there are some image for help

da...@google.com <da...@google.com> #3Oct 21, 2024 09:46PM

hello?

au...@google.com <au...@google.com> #4Oct 21, 2024 10:27PM

Note that I updated the topic to adjust for the recent prebuits/androidx/javascript-for-kotlin addition, so you might need to reapply it.

au...@google.com <au...@google.com> #5Oct 22, 2024 01:04AM

In CI, it seems to pretty consistently be crashing the JVM

https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3302866?checksPatchset=10&attempt=3&tab=checks

da...@google.com <da...@google.com> #6Oct 22, 2024 02:04PM

I still don't know the root cause of the native crash but when I have a clean checkout of the topic and do ./gradlew :room:room-gradle-plugin:test I see the crash. I have a feeling its happening because something might not be getting cleaned up when various tests are failing. We saw something similar with KSP2 where too many failures in XProcessing lead to OOMs.

With the following patch I don't see the crash anymore as more tests pass (only 3 failing, https://ge.androidx.dev/s/thnxupljnjcuw) but I am a bit worried about the extra attribute being added by KGP. I think it might cause real breakages if we start publishing KGP created artifacts libraries and Gradle module metadata with the 'release' attribute.

da...@google.com <da...@google.com> #7Oct 23, 2024 08:49PM

Chatted on the side with Aurimas, if you set kotlin.android.buildTypeAttribute.keep=false in the gradle.properties the Room Gradle Plugin tests pass, please add it to the topic.

da...@google.com <da...@google.com> #8Nov 19, 2024 05:53PM

Lowering to P2 as test will be temporarily disable to unblock Kotlin update: https://android-review.googlesource.com//c/platform/frameworks/support/+/3302866/30/room/room-gradle-plugin/src/test/java/androidx/room/gradle/RoomKmpGradlePluginTest.kt?checksPatchset=10

ap...@google.com <ap...@google.com> #9Nov 19, 2024 11:07PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <aurimas@google.com>
Link: https://android-review.googlesource.com/3302866

Upgrade to Kotlin 2.1.0-RC2

Expand for full commit details

Upgrade to Kotlin 2.1.0-RC2 
 
- Pin libs.kspApi to 2.0.10-1.0.24 as the next version targets Kotlin 
  2.0 and we dont want to force room, privacysandbox, and hilt to 
  require targeting Kotlin 2.0 just yet 
- Move annotation-experimental to Kotlin 1.8 as 1.7 has been deprecated 
- Update Compose compiler flags 
- Update API files to match https://youtrack.jetbrains.com/issue/KT-68824 
- Update ConstraintTest to account for new dependencyConstraint block 
- Update OffsetInformationTest based on new Kotlinc output 
- Removes kotlin.mpp.androidGradlePluginCompatibility.nowarn=true 
  that is no longer needed starting Kotlin 2.1.0, see 
  https://youtrack.jetbrains.com/issue/KT-69721 
- Adjust AddLicenses code to the fact that outputFile is now a directory 
  instead of a zip file. Zip file is created by a separate task that 
  follows 
- Remove MemoryModelTest as isExperimentalMM() is deprecated and always 
  returns true now 
- Disable crashing room-gradle-plugin RoomKmpGradlePluginTest 
- Make sure that Sbom tracking does not consider klib zip tasks as 
  embedding other libraries 
 
Bug: 374360882 
Relnote: N/A 
Test: ./gradlew bOS --dry-run 
      ./gradlew compose:runtime:runtime:build 
Change-Id: I87e4035c46d8111f8eb0a60ce5ffe1f337b0296c

Files:

M annotation/annotation-experimental/build.gradle
M binarycompatibilityvalidator/binarycompatibilityvalidator/src/main/java/androidx/binarycompatibilityvalidator/KLibDumpParser.kt
M buildSrc-tests/src/test/java/androidx/build/SdkResourceGeneratorTest.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXComposeImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/private/src/main/kotlin/androidx/build/ListTaskOutputsTask.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/KonanBuildService.kt
M buildSrc/private/src/main/kotlin/androidx/build/license/AddLicenses.kt
M buildSrc/private/src/main/kotlin/androidx/build/sbom/Sbom.kt
M buildSrc/public/src/main/kotlin/androidx/build/AndroidXConfiguration.kt
M collection/collection/bcv/native/current.txt
M collection/collection/build.gradle
D collection/collection/src/nativeTest/kotlin/androidx/collection/internal/MemoryModelTest.kt
M compose/ui/ui-tooling-data/src/androidInstrumentedTest/kotlin/androidx/compose/ui/tooling/data/OffsetInformationTest.kt
M core/core/integration-tests/publishing/src/test/kotlin/androidx/build/ConstraintTest.kt
M development/build_log_simplifier/messages.ignore
M development/update_kotlin.sh
M gradle.properties
M gradle/libs.versions.toml
M paging/paging-common/bcv/native/current.txt
M playground-common/androidx-shared.properties
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/KotlinMetadataTest.kt
M room/room-gradle-plugin/src/test/java/androidx/room/gradle/GradleTestUtils.kt
M room/room-gradle-plugin/src/test/java/androidx/room/gradle/RoomKmpGradlePluginTest.kt
M room/room-migration/bcv/native/current.txt

Hash: b90cd5d6e6ad71cb2c0557fc0ac7863f8ddf014a
Date: Wed Jul 17 18:58:36 2024

IssueTracker

:room:room-gradle-plugin:test crashing JVM when upgrading to KGP 2.1.0-RC-227

Status Update

Description

Instructions

Expected

Actual

Notes

Comments

da...@google.com <da...@google.com> #2Oct 21, 2024 04:57PM

da...@google.com <da...@google.com> #3Oct 21, 2024 09:46PM

au...@google.com <au...@google.com> #4Oct 21, 2024 10:27PM

au...@google.com <au...@google.com> #5Oct 22, 2024 01:04AM

da...@google.com <da...@google.com> #6Oct 22, 2024 02:04PM

da...@google.com <da...@google.com> #7Oct 23, 2024 08:49PM

da...@google.com <da...@google.com> #8Nov 19, 2024 05:53PM

ap...@google.com <ap...@google.com> #9Nov 19, 2024 11:07PM

Issue 374360882

Description

Instructions

Expected

Actual

Notes

Issue summary

Comments

da...@google.com <da...@google.com> #2Oct 21, 2024 04:57PM

da...@google.com <da...@google.com> #3Oct 21, 2024 09:46PM

au...@google.com <au...@google.com> #4Oct 21, 2024 10:27PM

au...@google.com <au...@google.com> #5Oct 22, 2024 01:04AM

da...@google.com <da...@google.com> #6Oct 22, 2024 02:04PM

da...@google.com <da...@google.com> #7Oct 23, 2024 08:49PM

da...@google.com <da...@google.com> #8Nov 19, 2024 05:53PM

ap...@google.com <ap...@google.com> #9Nov 19, 2024 11:07PM

Add comment

Issue metadata