Benchmarks - "Semantics Listener Interface" into androidx-main [374601314]

Assigned

Bug

Status Update

No update yet.

Description

pe...@skia-infra-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 21, 2024 06:46PM

Perf Regression (High) found, matching 40 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Test classes affected:

 androidx.compose.runtime.benchmark.collection.MutableVectorBenchmark
 androidx.compose.ui.benchmark.accessibility.AccessibilityBenchmark
 androidx.compose.ui.benchmark.accessibility.SemanticsEventsBenchmark
 androidx.compose.ui.benchmark.accessibility.TextAccessibilityBenchmark
 androidx.compose.ui.benchmark.accessibility.TextFieldAccessibilityBenchmark

Test methods affected:

 createAccessibilityNodeInfoFromId_singleOfMultipleTextComponents_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromId_singleOfMultipleTextField_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromId_singleTextComponent_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromId_singleTextField_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromRoot_multipleTextComponents_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 createAccessibilityNodeInfoFromRoot_multipleTextComponents_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromRoot_multipleTextField_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 createAccessibilityNodeInfoFromRoot_multipleTextField_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromRoot_singleTextComponent_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 createAccessibilityNodeInfoFromRoot_singleTextComponent_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 createAccessibilityNodeInfoFromRoot_singleTextField_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 fetchAccessibilityNodeInfo
 removeStartVector
 sendEvents_changeTextInMultipleTextComponents_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 sendEvents_changeTextInMultipleTextComponents_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 sendEvents_changeTextInOneOfMultipleText_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 sendEvents_changeTextInOneOfMultipleText_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 sendEvents_scrollTest_accessibilityEnabled___true__invalidateSemanticsOnEachRun___false_
 sendEvents_scrollTest_accessibilityEnabled___true__invalidateSemanticsOnEachRun___true_
 sendSemanticsEvents

Devices affected:

 aosp_mokey
 sargo

API Level:

 API_30_R
 API_31_S
 API_34_U

Comments

gr...@google.com <gr...@google.com> #2Oct 23, 2024 06:13PM

Reassigned to ra...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ec33fd30f60c310dc47ffeb481c79a50c16232f9
Author: Chris Craik <ccraik@google.com>
Date: Fri Apr 10 12:33:03 2020

Fix startupBenchmark in presubmit

Fixes: 153742334
Test: ./gradlew benchmark:integ-tests:startup-benchmark:cC # fails on device without locked clocks
Test: ./gradlew benchmark:integ-tests:startup-benchmark:cC -i -Pandroid.testInstrumentationRunnerArguments.notAnnotation=android.support.test.filters.FlakyTest,androidx.test.filters.FlakyTest # passes when we pass arg that presubmit passes

Skip StartupBenchmark when running in presubmit configuration by using
@FlakyTest.

Unfortunately, this seems to be the only easy way to skip the test,
without library-side complications. We can't early return from within
the test body, since then the Benchmark library complains that we
didn't include a benchmark block in our test.

The empty test may not be necessary for running in CI, but it does
allow the notAnnotation=FlakyTest gradle command above complete
successfully.

Change-Id: I143454e06f0458adbe71560d78e2ac11cfdc0bba

M benchmark/integration-tests/startup-benchmark/src/androidTest/java/androidx/benchmark/integration/startup/benchmark/ArgumentInjectingApplication.kt
A benchmark/integration-tests/startup-benchmark/src/androidTest/java/androidx/benchmark/integration/startup/benchmark/EmptyTest.kt
M benchmark/integration-tests/startup-benchmark/src/androidTest/java/androidx/benchmark/integration/startup/benchmark/StartupBenchmark.kt

https://android-review.googlesource.com/1284164

Issue 374601314

Description

Issue summary

Comments

gr...@google.com <gr...@google.com> #2Oct 23, 2024 06:13PM

Add comment

Issue metadata