WebView traffic tagging with TrafficStats [374932688]

Fixed

Feature Request

Unconfirmed

Status Update

No update yet.

Description

co...@google.com

created issue #1

Oct 22, 2024 12:11PM

What's your ask from the WebView team (implement an existing WP API, add a new developer API functionality, add a new JS API functionality, change the UX behaviour of a WebView):

Implement a new developer API to allow calling apps to tag the traffic and attribute it to other apps with TrafficStats. If it is easier, at least in the short term, it would be ok to just tag all of WebView traffic with one tag, value of which needs to be carefully chosen, and probably baked in the platform. In the long term I anticipate that we will still need to have the proper APIs.

Comments

ap...@google.com <ap...@google.com> #2Oct 31, 2024 02:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Nov 5, 2024 11:57AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Nov 7, 2024 05:52PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Nov 28, 2024 03:52PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Chidera Olibie <colibie@google.com>
Link: https://android-review.googlesource.com/3322934

[Webview] Add traffic tagging API

Expand for full commit details

[Webview] Add traffic tagging API 
 
This feature allows apps to attribute traffic in a socket to a 
specified tag. This means embedding apps can determine the 
traffic from Webview in their app using the android 
TrafficStats APIs. 
 
Bug: 374932688 
Test: webkit/run_instrumentation_tests.sh 
Change-Id: Ifdb259e6778269a2197377bb598c93238302ab55

Files:

M webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewCompatTest.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewCompat.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

Hash: e8f24349d9bc66ace7ebb16afd263a65afa592ab
Date: Mon Oct 28 15:02:19 2024

ap...@google.com <ap...@google.com> #6Nov 28, 2024 04:03PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Chidera Olibie <colibie@google.com>
Link: https://android-review.googlesource.com/3323419

[WebView] Add testapp activity for traffic stats

Expand for full commit details

[WebView] Add testapp activity for traffic stats 
 
Bug: 374932688 
Test: ./gradlew :webkit:integration-tests:testapp:installDebug # Default TrafficStats Tagging 
 
Change-Id: If3a7ab07a14d41822da3ebd170194caa84704d78

Files:

M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
A webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/DefaultTrafficStatsTaggingActivity.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/MainActivity.java
A webkit/integration-tests/testapp/src/main/res/layout/activity_default_traffic_tagging.xml
M webkit/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml

Hash: e9708420e10b98ad0e6a4d3e0da711f346eeeaf5
Date: Wed Oct 30 14:19:43 2024

ap...@google.com <ap...@google.com> #7Dec 2, 2024 12:16PM

Project: chromium/src
Branch: main
Author: Chidera Olibie <colibie@google.com>
Link: https://chromium-review.googlesource.com/6054142

[WV] Remove trafficstats tagging feature dev suffix

Expand for full commit details

[WV] Remove trafficstats tagging feature dev suffix 
 
Removing the dev suffix means it can be used on 
on non-userdebug devices, hencing allow for API call in prod. 
 
Bug: 374932688 
Change-Id: I2212a74fe45d2deb3f41a124d7ea8a494b38b730 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054142 
Reviewed-by: Peter Pakkenberg <pbirk@chromium.org> 
Auto-Submit: Chidera Olibie <colibie@google.com> 
Commit-Queue: Chidera Olibie <colibie@google.com> 
Cr-Commit-Position: refs/heads/main@{#1390267}

Files:

M android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Hash: d6708403ffada309de73c494318b00428ea6304d
Date: Mon Dec 02 12:14:16 2024

ap...@google.com <ap...@google.com> #8Dec 2, 2024 01:23PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Chidera Olibie <colibie@google.com>
Link: https://android-review.googlesource.com/3367782

[WebView] Unhide traffic stats tag API

Expand for full commit details

[WebView] Unhide traffic stats tag API 
 
Bug: 374932688 
Test: webkit/run_instrumentation_tests.sh 
Relnote: "Add socket tagging API to WebView for accounting of WebView's 
    network traffic using NetworkStatsManager/TrafficStats. This feature 
    will only be available from WebView M133." 
 
Change-Id: Ica4412c9432ff479ea728c30c09b1d7bf359d0f0

Files:

M webkit/webkit/api/current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/WebViewCompat.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

Hash: f64de1aa3a6f7a387508c73727476b7e17b48014
Date: Thu Nov 21 18:28:35 2024

co...@google.com <co...@google.com> Dec 5, 2024 01:38PM

Marked as fixed.

pr...@google.com <pr...@google.com> #9Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.webkit:webkit:1.13.0-alpha02

IssueTracker

This issue is a part of the Chromium tracker.