Status Update
Comments
jo...@meterapp.co <jo...@meterapp.co> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavGraphBuilder nested graph DSL
Expand for full commit details
Add non-reified NavGraphBuilder nested graph DSL
Test: ./gradlew navigation:navigation-common:cC
Bug: 382094941
Relnote: "Added non-reified NavGraphBuilder.navigation extention functions to build a nested graph with route from KClass<T>"
Change-Id: Ibf24453e66d69c00d4ffb3abe4dc5a1f3782ad09
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphBuilderTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavGraphBuilder.kt
Hash: 94c09a993d68e5c57172c3e3bc418e35ec57f2fc
Date: Tue Dec 03 16:52:10 2024
jo...@meterapp.co <jo...@meterapp.co> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavGraph.findNode safe args api
Expand for full commit details
Add non-reified NavGraph.findNode safe args api
Test: ./gradlew navigation:navigation-common:cC
Bug: 382094941
Relnote: "Added non-reified NavGraph.findNode API to find node with KClass<*>"
Change-Id: I54696ee5ce64305386de64654c6ce15f3a1fd741
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
Hash: 3c80f14b77e8f2f84f961b24de924439fc009ad7
Date: Tue Dec 03 13:15:22 2024
bi...@gmail.com <bi...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavDeepLink.Builder.setUriPattern safe args api
Expand for full commit details
Add non-reified NavDeepLink.Builder.setUriPattern safe args api
Test: existing tests
Bug: 382094941
Relnote: "Added non-reified NavDeepLink.Builder.setUriPattern API to add set deepLink Uri pattern with KClass<*>"
Change-Id: Ia47be2a0ac9e2b8ef5def4aa808b939e15259d2a
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
Hash: 92ab76b0551be25fab92d2884a8c0c06a521af41
Date: Tue Dec 03 13:06:15 2024
[Deleted User] <[Deleted User]> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavDestinationBuilder.deepLink safe args api
Expand for full commit details
Add non-reified NavDestinationBuilder.deepLink safe args api
Test: ./gradlew navigation:navigation-common:cC
Bug: 382094941
Relnote: "Added non-reified NavDestinationBuilder.deepLink API to add a deeplink with KClass<*>"
Change-Id: I93281ed88fe3be9e6c68a2d5f16d9e0f335c999d
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationBuilderTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt
Hash: 3de22e912b5752790370c40acdc03de4d0985933
Date: Tue Dec 03 12:57:11 2024
8h...@gmail.com <8h...@gmail.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavOptionsBuilder.popUpTo safe args api
Expand for full commit details
Add non-reified NavOptionsBuilder.popUpTo safe args api
Test: ./gradlew navigation:navigation-common:cC
Bug: 382094941
Relnote: "Added non-reified NavOptionsBuilder.popUpTo API to set popUpTo destination with KClass<T>"
Change-Id: Id09d2f511e9844b0618140781f07bebe1e7deb77
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/NavOptionsBuilderTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavOptionsBuilder.kt
Hash: e9d6539c2369ec0e0de4bccd18e890432cab86c2
Date: Tue Dec 03 14:33:41 2024
jo...@meterapp.co <jo...@meterapp.co> #7
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavOptions.Builder.setPopUpTo safe args api
Expand for full commit details
Add non-reified NavOptions.Builder.setPopUpTo safe args api
Test: existing tests
Bug: 382094941
Relnote: "Added non-reified NavOptions.Builder.setPopUpTo API to set popUpTo destination with KClass<T>"
Change-Id: I17d79479d8a1f2acda8f6767a40ff19773235d9d
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.kt
Hash: 30bf6328f0dac6fc20aad820586cbe88c949cae2
Date: Tue Dec 03 14:44:33 2024
pa...@wewell.app <pa...@wewell.app> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavDeepLinkDSLBuilder.navDeepLink safe args api
Expand for full commit details
Add non-reified NavDeepLinkDSLBuilder.navDeepLink safe args api
Test: ./gradlew navigation:navigation-common:cC
Bug: 382094941
Relnote: "Added non-reified NavDeepLinkDSLBuilder.navDeepLink API to add a NavDeepLink with KClass<T>"
Change-Id: Id28791416c67c0b4930370ded037ffb3c40922b6
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkBuilderTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLinkDslBuilder.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt
Hash: 1f8d26c4db6329f6a726f317b2983cd5c7d8ea78
Date: Wed Dec 04 10:30:52 2024
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Add non-reified NavGraph.setStartDestination safe args api
Expand for full commit details
Add non-reified NavGraph.setStartDestination safe args api
Test: ./gradlew navigation:navigation-common:cC
Bug: 382094941
Relnote: "Added non-reified NavGraph.setStartDestination API to set a graph’s startDestination with KClass<T>"
Change-Id: Ia7eed5b9c0fe15834468d3eccc489c2dc3edca74
Files:
- M
navigation/navigation-common/api/current.txt
- M
navigation/navigation-common/api/restricted_current.txt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
Hash: 9e0a95788cbe0b0f44e1bafd1c93a086aced0ccb
Date: Wed Dec 04 10:40:39 2024
[Deleted User] <[Deleted User]> #10
Fixed internally and available in navigation-2.9.0-alpha04
jb...@google.com <jb...@google.com> #11
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.9.0-alpha04
jo...@meterapp.co <jo...@meterapp.co> #12
Thank you so much for your hard work and persistence on this issue! Really excited for the 2.8.5 release :)
sh...@navi.com <sh...@navi.com> #13
by when can i expect 2.8.5 to hit stable and be available to use?
jo...@meterapp.co <jo...@meterapp.co> #14
by when can i expect 2.8.5 to hit stable and be available to use?
Based on the androidx release schedule, I'd assume it will be available December 11th. It looks like they skipped the thanksgiving release for most libraries and I'm hoping they'll be back with releases December 11th.
pr...@google.com <pr...@google.com> #15
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-compose:2.9.0-alpha04
androidx.navigation:navigation-compose:2.8.5
si...@gmail.com <si...@gmail.com> #16
I can confirm that our usual way of reproducing this issue with the debugger no longer crashes. Thanks a lot for this release!
sa...@gmail.com <sa...@gmail.com> #17
ma...@wm.rs <ma...@wm.rs> #18
Hi, I'm still facing the issue with 2.8.5
The stack trace:
Fatal Exception: java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1
at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
at java.util.Objects.checkIndex(Objects.java:359)
at java.util.ArrayList.get(ArrayList.java:434)
at androidx.navigation.compose.NavHostKt$NavHost$28$1.invokeSuspend(NavHost.kt:620)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at android.app.ActivityThread.main(ActivityThread.java:9063)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:588)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)
It's seems the issue now is in val previousEntry = currentBackStack[currentBackStack.size - 2]
:
if (inPredictiveBack) {
LaunchedEffect(progress) {
val previousEntry = currentBackStack[currentBackStack.size - 2]
transitionState.seekTo(progress, previousEntry)
}
}
si...@gmail.com <si...@gmail.com> #19
Filed
Description
Component used: Activity
Versions used:
Devices/Android versions reproduced on: Pixel 7 API 35 (emulator)
Sample project:https://github.com/sindrenm/compose-navigation-crash-repro
This is a follow-up to 340202286 , since #39 requested we open a new issue. I have a sample project (linked above) that reproduces the issue consistently by using the debugger, but we're also seeing this crash happen for our users (same stack trace) in production builds with the same library versions. Note that we have not been able to reproduce it locally without using the debugger, but our users are.
The stack trace is as follows: