Rename state parameter on Modifier.sharedElement to match same naming as Modifier.sharedBounds [375351468]

Fixed

Feature Request

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Oct 24, 2024 10:17AM

Modifier.sharedElement state parameter is named differently from Modifier.sharedBounds, making switching between the two a bit more cumbersome than needed.

    override fun Modifier.sharedElement(
        state: SharedContentState,
        animatedVisibilityScope: AnimatedVisibilityScope,

and Modifier.sharedBounds:

    override fun Modifier.sharedBounds(
        sharedContentState: SharedContentState,

It is desirable to have these consistent names between the two.

Comments

ap...@google.com <ap...@google.com> #2Oct 25, 2024 06:24PM

Marked as fixed.

Any news on this issue?

na...@google.com <na...@google.com> #3Nov 13, 2024 06:19PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Android build
Which Android build are you using? (e.g. OPP1.170223.012)

Device used
Which device did you use to reproduce this issue?

Steps to reproduce
What steps are needed to reproduce this issue?

Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.

Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.

Issue 375351468

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Oct 25, 2024 06:24PM

na...@google.com <na...@google.com> #3Nov 13, 2024 06:19PM

Add comment

Issue metadata