Rename state parameter on Modifier.sharedElement to match same naming as Modifier.sharedBounds [375351468]

Fixed

Feature Request

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Oct 24, 2024 10:17AM

Modifier.sharedElement state parameter is named differently from Modifier.sharedBounds, making switching between the two a bit more cumbersome than needed.

    override fun Modifier.sharedElement(
        state: SharedContentState,
        animatedVisibilityScope: AnimatedVisibilityScope,

and Modifier.sharedBounds:

    override fun Modifier.sharedBounds(
        sharedContentState: SharedContentState,

It is desirable to have these consistent names between the two.

Comments

ap...@google.com <ap...@google.com> #2Oct 25, 2024 06:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 700259f0afe267dfe78b93db932a3cfd827a119d
Author: Sherry Hu <shuanghu@google.com>
Date: Mon May 10 14:23:09 2021

Add transition motion between fold and unfold.

Bug: 186211031
Test: manual
Change-Id: Id60f07311eca2d94ef91dc28ae45823a475160b4

M slidingpanelayout/slidingpanelayout/build.gradle
M slidingpanelayout/slidingpanelayout/src/androidTest/java/androidx/slidingpanelayout/widget/FoldTest.kt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/1702066

na...@google.com <na...@google.com> #3Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.animation:animation:1.8.0-alpha06
androidx.compose.animation:animation-android:1.8.0-alpha06
androidx.compose.animation:animation-jvmstubs:1.8.0-alpha06
androidx.compose.animation:animation-linuxx64stubs:1.8.0-alpha06

Issue 375351468

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Oct 25, 2024 06:24PM

na...@google.com <na...@google.com> #3Nov 13, 2024 06:19PM

Add comment

Issue metadata