Rename state parameter on Modifier.sharedElement to match same naming as Modifier.sharedBounds [375351468]

Fixed

Feature Request

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Oct 24, 2024 10:17AM

Modifier.sharedElement state parameter is named differently from Modifier.sharedBounds, making switching between the two a bit more cumbersome than needed.

    override fun Modifier.sharedElement(
        state: SharedContentState,
        animatedVisibilityScope: AnimatedVisibilityScope,

and Modifier.sharedBounds:

    override fun Modifier.sharedBounds(
        sharedContentState: SharedContentState,

It is desirable to have these consistent names between the two.

Comments

ap...@google.com <ap...@google.com> #2Oct 25, 2024 06:24PM

Marked as fixed.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

na...@google.com <na...@google.com> #3Nov 13, 2024 06:19PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Issue 375351468

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Oct 25, 2024 06:24PM

na...@google.com <na...@google.com> #3Nov 13, 2024 06:19PM

Add comment

Issue metadata