Make AutofillManager as non-expect interface [376080755]

Fixed

Bug

Status Update

No update yet.

Description

ig...@jetbrains.com

created issue #1

Oct 29, 2024 03:52PM

- Jetpack Compose version: androidx-main, 0be31ce
- Jetpack Compose component used: AutofillManager

AutofillManager was transformed from common interface to an expect class in

https://android-review.googlesource.com/c/platform/frameworks/support/+/3313535/3/compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/autofill/AutofillManager.kt#25

Can it be reverted back to non-expect interface before the 1.8 API freeze? The reasoning is described in the linked comment.

It is not critical, as this seems as compatible change, but it can complicate adoption for multiplatform.

Comments

mn...@google.com <mn...@google.com> Oct 29, 2024 04:24PM

Reassigned to mn...@google.com.

se...@google.com <se...@google.com> #2Oct 29, 2024 10:54PM

This is similar to this bug report as well: https://issuetracker.google.com/issues/172590946

ig...@jetbrains.com <ig...@jetbrains.com> #3Oct 30, 2024 01:10PM

Hi Yinglei, re-assigning back to you as you're currently working on exactly this for Snackbars.

Message last modified on Oct 30, 2024 01:14PM

se...@google.com <se...@google.com> #4Oct 30, 2024 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 506fcdecc2dc257b58c574006d70ea9ce6f0bfda
Author: Yinglei Wang <yingleiw@google.com>
Date: Fri Feb 26 15:58:00 2021

add semantics liveRegion and apply it to snackbar

Snackbar should be marked as live region for accessibility. When talkback
is on, the snackbar is announced when it appears. Also added dismiss
action for the snackbar.

Note that since we are not merging up the tree for subtree change
events, we don't need to do extra work for live region. From android
documentation and discussion with Phil, the throttling delay is fine for
accessibility events from live region.

Relnote: "LiveRegion accessibility API is added.
If node is marked as a live region, the accessibility services
will automatically notify the user about its changes"

Fix:

b/153644625

b/172590946

b/182834687

Test: tested manully with talkback on. Unit tests added.

Change-Id: Idcf6f425b12b005e59ad77fe7430e466132ea87c

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SnackbarHostTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
M compose/ui/ui/api/1.0.0-beta04.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta04.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta04.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1580798

ap...@google.com <ap...@google.com> #5Nov 1, 2024 10:38PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Melba Nuzen <mnuzen@google.com>
Link: https://android-review.googlesource.com/3323771

Refactor Autofill manager from expect/actual to interface

Expand for full commit details

Refactor Autofill manager from expect/actual to interface 
 
This CL also lifts the `requestAutofillForActiveElement` into common. Since the text toolbar changes in aosp/3312341 were added when `requestAutofill` was an Android-only API, this CL also removes all the logic added in that CL that was needed when the API was not in common. 
 
See comments in aosp/3313535 for more notes. 
 
Test: ensure existing tests pass 
Fixes: 376080755 
RelNote: "Changes Autofill manager to be an interface." 
Change-Id: I8491407de5699bf7273b9f88bda11cc438e2fd62

Files:

M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/selection/TextFieldSelectionState.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/selection/TextFieldSelectionState.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
D compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/selection/TextFieldSelectionState.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.commonStubs.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/autofill/AndroidAutofillManagerTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AndroidAutofillManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/autofill/AutofillManager.kt
D compose/ui/ui/src/commonStubsMain/kotlin/androidx/compose/ui/autofill/AutofillManager.commonStubs.kt

Hash: 88e844c277eaf5cd576e4a4075e63632600c78f8
Date: Tue Oct 29 11:28:54 2024

na...@google.com <na...@google.com> #6Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
androidx.compose.ui:ui:1.8.0-alpha06
androidx.compose.ui:ui-android:1.8.0-alpha06
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha06
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha06

Issue 376080755