Make AutofillManager as non-expect interface [376080755]

Fixed

Bug

Status Update

No update yet.

Description

ig...@jetbrains.com

created issue #1

Oct 29, 2024 03:52PM

- Jetpack Compose version: androidx-main, 0be31ce
- Jetpack Compose component used: AutofillManager

AutofillManager was transformed from common interface to an expect class in

https://android-review.googlesource.com/c/platform/frameworks/support/+/3313535/3/compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/autofill/AutofillManager.kt#25

Can it be reverted back to non-expect interface before the 1.8 API freeze? The reasoning is described in the linked comment.

It is not critical, as this seems as compatible change, but it can complicate adoption for multiplatform.

Comments

mn...@google.com <mn...@google.com> Oct 29, 2024 04:24PM

Reassigned to mn...@google.com.

se...@google.com <se...@google.com> #2Oct 29, 2024 10:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Oct 31 11:30:30 2019

Remove font related TODOs

- Ability to read font weight from the font

b/143700963

- Support for font collections

b/122476423

- Support for variable fonts

b/143703328

- support for multiple font family

b/127483182

- BaselineShift.lerp

b/143699225

Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest

Bug: 141645236
Bug: 143700963
Bug: 122476423
Bug: 143703328
Bug: 127483182
Bug: 143699225
Change-Id: I4ff001fd1e0fff4cd3aa0c64efae929057e8d5de

M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/main/java/androidx/ui/text/font/Font.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/AndroidParagraphHelper.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/TypefaceAdapter.kt
M ui/ui-text/src/main/java/androidx/ui/text/style/BaselineShift.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontFamilyTest.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontTest.kt

https://android-review.googlesource.com/1156568

https://goto.google.com/android-sha1/c9e90d1e5671b7e6a8880aecbe32bb13f4b37560

ig...@jetbrains.com <ig...@jetbrains.com> #3Oct 30, 2024 01:10PM

from dupped ticket

"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.

Note:
Tracking ticket based on

https://docs.google.com/document/d/1MzK83egP-Jghc2ZW8IcIcJkud_vMM7jgDClCv4CkO_c/edit#bookmark=id.nyju92hr2ygw"

Message last modified on Oct 30, 2024 01:14PM

se...@google.com <se...@google.com> #4Oct 30, 2024 05:21PM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ap...@google.com <ap...@google.com> #5Nov 1, 2024 10:38PM

Marked as fixed.

discussion from aosp/1672420

variable font settings can be included during font creation (for Font() functions.)

there are two parts of the story:

This font is weight X
I want to render the text in weight Y (regardless of the font weight)

na...@google.com <na...@google.com> #6Nov 13, 2024 06:19PM

important for Material.

Issue 376080755