Benchmarks - Regression between Merge "Add unit tests for Camera2CameraController restarts" into androidx-main and Merge "Coordinate the state changes between pane snapping and switching" into androidx-main [376394520]

Fixed

Bug

Status Update

No update yet.

Description

pe...@skia-infra-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 30, 2024 08:24AM

Perf Regression (High) found, matching 22 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Test classes affected:

 androidx.compose.material3.adaptive.benchmark.ListDetailPaneScaffoldBenchmark
 androidx.compose.material3.adaptive.benchmark.SupportingPaneScaffoldBenchmark

Test methods affected:

 dualPane_firstCompose
 dualPane_firstPixel
 singlePane_firstCompose
 singlePane_firstPixel

Devices affected:

 aosp_mokey
 sargo

API Level:

 API_30_R
 API_31_S
 API_34_U

Comments

be...@google.com <be...@google.com> #2Nov 7, 2024 07:00PM

Reassigned to co...@google.com.

Exito

co...@google.com <co...@google.com> #3Nov 7, 2024 07:06PM

I know Louis has been looking at this already.

co...@google.com <co...@google.com> Nov 12, 2024 08:22PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #4Nov 13, 2024 03:24AM

I think, clickable/combinedClickable must be replaced with separated modifiers (as focus.../onFocus...). I propose to make:

new pressable(enabled, interactionSource) modifier which does not have an indication, hoverable and focusable/focusableInNonTouchMode. interactionSource will only be used with PressInteraction.
new modifier(s) for onClickLabel/onClick, onLongClickLabel/onLongClick and onDoubleClick.
focusableInNonTouchMode public.

We can add role separately via semantics.

All this will help to create components with the necessary properties.

co...@google.com <co...@google.com> Nov 15, 2024 06:36PM

Marked as fixed.

Issue 376394520