Benchmarks - Regression between Merge "Add unit tests for Camera2CameraController restarts" into androidx-main and Merge "Coordinate the state changes between pane snapping and switching" into androidx-main [376394520]

Fixed

Bug

Status Update

No update yet.

Description

pe...@skia-infra-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 30, 2024 08:24AM

Perf Regression (High) found, matching 22 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Test classes affected:

 androidx.compose.material3.adaptive.benchmark.ListDetailPaneScaffoldBenchmark
 androidx.compose.material3.adaptive.benchmark.SupportingPaneScaffoldBenchmark

Test methods affected:

 dualPane_firstCompose
 dualPane_firstPixel
 singlePane_firstCompose
 singlePane_firstPixel

Devices affected:

 aosp_mokey
 sargo

API Level:

 API_30_R
 API_31_S
 API_34_U

Comments

be...@google.com <be...@google.com> #2Nov 7, 2024 07:00PM

Reassigned to co...@google.com.

The reason this has not been seen before now is that JDK-8272564 was done for JDK-18 and that it also require min API level 28. The reason the Espresso library expose this is that (most likely) internal Google build tools have JDK-8272564 applied generating invoke-interface on Object methods.

co...@google.com <co...@google.com> #3Nov 7, 2024 07:06PM

Project: r8
Branch: main

commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Fixes:

b/271408544

Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6

M src/main/java/com/android/tools/r8/utils/InternalOptions.java

https://r8-review.googlesource.com/76861

co...@google.com <co...@google.com> Nov 12, 2024 08:22PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #4Nov 13, 2024 03:24AM

Project: r8
Branch: main

commit 9e5692c8ce91b3ea3f4199740b41d57c097c9947
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:40:44 2023

Fix test after changing API level for rewriting of JDK-8272564

Bug:

b/271408544

Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653

M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java

https://r8-review.googlesource.com/76885

co...@google.com <co...@google.com> Nov 15, 2024 06:36PM

Marked as fixed.

Issue 376394520