Benchmarks - Regression between Merge "Add unit tests for Camera2CameraController restarts" into androidx-main and Merge "Coordinate the state changes between pane snapping and switching" into androidx-main [376394520]

Fixed

Bug

Status Update

No update yet.

Description

pe...@skia-infra-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 30, 2024 08:24AM

Perf Regression (High) found, matching 22 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Test classes affected:

 androidx.compose.material3.adaptive.benchmark.ListDetailPaneScaffoldBenchmark
 androidx.compose.material3.adaptive.benchmark.SupportingPaneScaffoldBenchmark

Test methods affected:

 dualPane_firstCompose
 dualPane_firstPixel
 singlePane_firstCompose
 singlePane_firstPixel

Devices affected:

 aosp_mokey
 sargo

API Level:

 API_30_R
 API_31_S
 API_34_U

Comments

be...@google.com <be...@google.com> #2Nov 7, 2024 07:00PM

Reassigned to co...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

co...@google.com <co...@google.com> #3Nov 7, 2024 07:06PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

co...@google.com <co...@google.com> Nov 12, 2024 08:22PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #4Nov 13, 2024 03:24AM

Project: platform/frameworks/support
Branch: androidx-main
Author: drchen <conradchen@google.com>
Link: https://android-review.googlesource.com/3344233

Fix performance regression caused by rememberPaneExpansionState

Expand for full commit details

Fix performance regression caused by rememberPaneExpansionState 
 
The regression is caused by the introduction of LaunchEffect in the 
remember function, which is required to keep the state correctly between 
scaffold value changes. 
 
However, when paneExpansionDragHandle is not provided, there's no way 
for devs to mutate the default paneExpansionState. In this case, we can 
avoid a lot of management overhead by just providing a stub 
implementation. 
 
Relnote: Makes pane expansion state null by default 
Test: benchmarks and existing instrumentation tests 
Bug: 376394520 
Change-Id: Ia65f8919ba9aaaa4c611ecb40514ee41d1e8d56f

Files:

M compose/material3/adaptive/adaptive-layout/api/current.txt
M compose/material3/adaptive/adaptive-layout/api/restricted_current.txt
M compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/ListDetailPaneScaffold.kt
M compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/PaneExpansionState.kt
M compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/SupportingPaneScaffold.kt
M compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/ThreePaneScaffold.kt
M compose/material3/adaptive/adaptive-navigation/api/current.txt
M compose/material3/adaptive/adaptive-navigation/api/restricted_current.txt
M compose/material3/adaptive/adaptive-navigation/src/androidMain/kotlin/androidx/compose/material3/adaptive/navigation/AndroidThreePaneScaffold.android.kt

Hash: 53e5f16e76ae8e1b81468649f4bcc5ec8c06d05f
Date: Tue Nov 12 12:14:14 2024

co...@google.com <co...@google.com> Nov 15, 2024 06:36PM

Marked as fixed.

Issue 376394520