Text's inlineContent is not added to TalkBack in 1.7 [376479686]

Verified

Bug

Status Update

No update yet.

Description

si...@gmail.com

created issue #1

Oct 31, 2024 09:34AM

Jetpack Compose version: 1.7.5

Jetpack Compose component(s) used: foundation

Steps to Reproduce or Code Sample to Reproduce:

BasicText(
    text = buildAnnotatedString {
        append("Outer text")
        appendInlineContent("info")
    },
    inlineContent = mapOf("info" to InlineTextContent(Placeholder(16.sp, 16.sp, Center), {
        Icon(Icons.Default.Warning, contentDescription = "Important warning")
    }))
)

TalkBack TreeDebug logs:

Version 1.6.8 (BOM 2024.08.00)

Window: AccessibilityWindowInfo[title=My Application, displayId=0, id=39, type=TYPE_APPLICATION, layer=0, region=SkRegion((0,0,1080,2400)), bounds=Rect(0, 0 - 1080, 2400), focused=true, active=true, pictureInPicture=false, hasParent=false, isAnchored=false, hasChildren=false]
 (-2147455771)39.FrameLayout:(0, 0 - 1080, 2400):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (33643)39.View:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS)(custom action)
 (33767)39.TextView:(112, 149 - 329, 202):TEXT{Outer text�}:GRANULARITY{31}(action:CLEAR_A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):accessibilityFocused:supportsTextLocation
 (33829)39.ImageView:(284, 153 - 329, 198):CONTENT{Important warning}:GRANULARITY{11}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):screenReaderfocusable

Notice last line - "Important warning" is present

Version 1.7.5 (BOM 2024.10.01)

Window: AccessibilityWindowInfo[title=My Application, displayId=0, id=42, type=TYPE_APPLICATION, layer=0, region=SkRegion((0,0,1080,2400)), bounds=Rect(0, 0 - 1080, 2400), focused=true, active=true, pictureInPicture=false, hasParent=false, isAnchored=false, hasChildren=false]
 (-2147455768)42.FrameLayout:(0, 0 - 1080, 2400):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (33646)42.View:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS)(custom action)
 (33770)42.TextView:(112, 149 - 329, 202):TEXT{Outer text�}:GRANULARITY{31}(action:CLEAR_A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):screenReaderfocusable:accessibilityFocused:supportsTextLocation

There "Important warning" is missing

Version 1.8.0-alpha05 (BOM-alpha 2024.10.01)

Window: AccessibilityWindowInfo[title=My Application, displayId=0, id=44, type=TYPE_APPLICATION, layer=0, region=SkRegion((0,0,1080,2400)), bounds=Rect(0, 0 - 1080, 2400), focused=true, active=true, pictureInPicture=false, hasParent=false, isAnchored=false, hasChildren=false]
 (-2147455766)44.FrameLayout:(0, 0 - 1080, 2400):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (32687)44.ComposeView:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (33648)44.View:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS)(custom action)
 (33772)44.TextView:(112, 149 - 329, 202):TEXT{Outer text�}:GRANULARITY{31}(action:CLEAR_A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):accessibilityFocused:supportsTextLocation
 (33834)44.ImageView:(284, 153 - 329, 198):CONTENT{Important warning}:GRANULARITY{11}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):screenReaderfocusable

There "Important warning" is back again

It seems like this regression was added in Icd0becab6818712ab7fa6f3abe83f441a841af5e and fixed in I531e7bad97cda327974696686357a9e56430a6a6 (see TextAnnotatedStringNode.shouldClearDescendantSemantics). Although it is fixed in 1.8-alpha, version 1.7 is broken, preventing our app from updating.

Comments

mo...@google.com <mo...@google.com> Nov 6, 2024 05:31PM

Assigned to an...@google.com.

gr...@google.com <gr...@google.com> #2Nov 7, 2024 06:24PM

Reassigned to gr...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Message last modified on Nov 8, 2024 12:28AM

gr...@google.com <gr...@google.com> #3Nov 8, 2024 09:03PM

1.7 cherry pick cl: https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3341487

Add test to ToT cl: https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3340855

Cherry pick bug: b/378121688

ap...@google.com <ap...@google.com> #4Nov 12, 2024 10:47PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Grant Toepfer <grantapher@google.com>
Link: https://android-review.googlesource.com/3340855

Add test for text inline content semantics

Expand for full commit details

Add test for text inline content semantics 
 
Adds a test for a cherry-pick in 1.7, see aosp/3341487. 
 
Bug: b/376479686 
Test: androidx.compose.foundation.text.BasicTextSemanticsTest.inlineContentSemantics_matchesInMergedSemantics 
Change-Id: I22c5be1bf542a390e7d6d14851a1134787fb2028

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/BasicTextSemanticsTest.kt

Hash: 21332df933adc3afa9bdee0fb729d6ed81d83669
Date: Thu Nov 07 17:16:32 2024

gr...@google.com <gr...@google.com> #5Dec 2, 2024 07:24PM

update to cherry pick: https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3376831 then https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3341487 into 1.7. Currently hung up on a cross-module experimental annotation usage.

gr...@google.com <gr...@google.com> #6Dec 4, 2024 12:42AM

Cherry pick complete, https://r.android.com/3376831, https://r.android.com/3387946, and https://r.android.com/3341487 in order are targeting 1.7.6.

Sibling CL https://r.android.com/3387948 is merged into main as cleanup in 1.8.

gr...@google.com <gr...@google.com> #7Dec 4, 2024 12:42AM

Reassigned to bu...@google.com.

Bugjuggler: wait 12d

ap...@google.com <ap...@google.com> #8Dec 4, 2024 12:42AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Grant Toepfer <grantapher@google.com>
Link: https://android-review.googlesource.com/3387948

Stabilize invisibleToUser

Expand for full commit details

Stabilize `invisibleToUser` 
 
A 1.7 cherry-pick (aosp/3341487) to fix b/376479686 calls `invisibleToUser` from the foundation module, but it cannot depend on `invisibleToUser` if it is still experimental, so experimental was removed from `invisibleToUser` in 1.7 (via aosp/3387946). This change removes experimental from `invisibleToUser` in 1.8+ so that it matches the change in 1.7 for binary compatibility. 
 
Leaving relnote blank since `invisibleToUser` is still deprecated in 1.8+ 
 
Relnote: N/A 
 
Bug: b/376479686 
Test: N/A 
Change-Id: I40cdd6a3d335011e890761560a5a3416aa579991

Files:

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/SemanticsUtils.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

Hash: 211cbf6550baa068eb56bf80d767c5ef1e882674
Date: Mon Dec 02 16:33:49 2024

gr...@google.com <gr...@google.com> Dec 4, 2024 12:43AM

Status: Assigned (reopened)

bu...@google.com <bu...@google.com> #9Dec 4, 2024 12:43AM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2024-12-15 16:42 -0800 PST and then assign the bug to grantapher@google.com.

gr...@google.com <gr...@google.com> #10Dec 4, 2024 12:43AM

Assigned to bu...@google.com.

Bugjuggler: wait 12d

bu...@google.com <bu...@google.com> #11Dec 4, 2024 12:43AM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2024-12-15 16:43 -0800 PST and then assign the bug to grantapher@google.com.

gr...@google.com <gr...@google.com> #12Dec 11, 2024 10:11PM

Marked as fixed, reassigned to gr...@google.com.

Should be fixed in compose foundation 1.7.6. Reporter, please verify your use case is working.

si...@gmail.com <si...@gmail.com> #13Dec 12, 2024 09:22AM

Can confirm the fix is working in 1.7.6

gr...@google.com <gr...@google.com> #14Dec 12, 2024 05:51PM

Verified by gr...@google.com.

Thank you!