Text's inlineContent is not added to TalkBack in 1.7 [376479686]

Verified

Bug

Status Update

No update yet.

Description

si...@gmail.com

created issue #1

Oct 31, 2024 09:34AM

Jetpack Compose version: 1.7.5

Jetpack Compose component(s) used: foundation

Steps to Reproduce or Code Sample to Reproduce:

BasicText(
    text = buildAnnotatedString {
        append("Outer text")
        appendInlineContent("info")
    },
    inlineContent = mapOf("info" to InlineTextContent(Placeholder(16.sp, 16.sp, Center), {
        Icon(Icons.Default.Warning, contentDescription = "Important warning")
    }))
)

TalkBack TreeDebug logs:

Version 1.6.8 (BOM 2024.08.00)

Window: AccessibilityWindowInfo[title=My Application, displayId=0, id=39, type=TYPE_APPLICATION, layer=0, region=SkRegion((0,0,1080,2400)), bounds=Rect(0, 0 - 1080, 2400), focused=true, active=true, pictureInPicture=false, hasParent=false, isAnchored=false, hasChildren=false]
 (-2147455771)39.FrameLayout:(0, 0 - 1080, 2400):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (33643)39.View:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS)(custom action)
 (33767)39.TextView:(112, 149 - 329, 202):TEXT{Outer text�}:GRANULARITY{31}(action:CLEAR_A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):accessibilityFocused:supportsTextLocation
 (33829)39.ImageView:(284, 153 - 329, 198):CONTENT{Important warning}:GRANULARITY{11}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):screenReaderfocusable

Notice last line - "Important warning" is present

Version 1.7.5 (BOM 2024.10.01)

Window: AccessibilityWindowInfo[title=My Application, displayId=0, id=42, type=TYPE_APPLICATION, layer=0, region=SkRegion((0,0,1080,2400)), bounds=Rect(0, 0 - 1080, 2400), focused=true, active=true, pictureInPicture=false, hasParent=false, isAnchored=false, hasChildren=false]
 (-2147455768)42.FrameLayout:(0, 0 - 1080, 2400):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (33646)42.View:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS)(custom action)
 (33770)42.TextView:(112, 149 - 329, 202):TEXT{Outer text�}:GRANULARITY{31}(action:CLEAR_A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):screenReaderfocusable:accessibilityFocused:supportsTextLocation

There "Important warning" is missing

Version 1.8.0-alpha05 (BOM-alpha 2024.10.01)

Window: AccessibilityWindowInfo[title=My Application, displayId=0, id=44, type=TYPE_APPLICATION, layer=0, region=SkRegion((0,0,1080,2400)), bounds=Rect(0, 0 - 1080, 2400), focused=true, active=true, pictureInPicture=false, hasParent=false, isAnchored=false, hasChildren=false]
 (-2147455766)44.FrameLayout:(0, 0 - 1080, 2400):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (32687)44.ComposeView:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action)
 (33648)44.View:(0, 0 - 441, 309):GRANULARITY{0}(action:A11Y_FOCUS)(custom action)
 (33772)44.TextView:(112, 149 - 329, 202):TEXT{Outer text�}:GRANULARITY{31}(action:CLEAR_A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):accessibilityFocused:supportsTextLocation
 (33834)44.ImageView:(284, 153 - 329, 198):CONTENT{Important warning}:GRANULARITY{11}(action:A11Y_FOCUS/SCROLL_TO_POSITION)(custom action):screenReaderfocusable

There "Important warning" is back again

It seems like this regression was added in Icd0becab6818712ab7fa6f3abe83f441a841af5e and fixed in I531e7bad97cda327974696686357a9e56430a6a6 (see TextAnnotatedStringNode.shouldClearDescendantSemantics). Although it is fixed in 1.8-alpha, version 1.7 is broken, preventing our app from updating.

Comments

mo...@google.com <mo...@google.com> Nov 6, 2024 05:31PM

Assigned to an...@google.com.

gr...@google.com <gr...@google.com> #2Nov 7, 2024 06:24PM

Reassigned to gr...@google.com.

George, you fixed this issue now right?

Message last modified on Nov 8, 2024 12:28AM

gr...@google.com <gr...@google.com> #3Nov 8, 2024 09:03PM

I see the release note in compose-ui 1.7.3:

Fixed exception thrown when the IME is active on an external View and the Next action is used to enter focus on the ComposeView. The clearFocus() behavior aligns with View behavior on API < 28, where clearFocus() can cause the default View to be focused.

However, we can still reproduce this crash with BOM 2024.09.03 and compose-ui 1.7.3.

ap...@google.com <ap...@google.com> #4Nov 12, 2024 10:47PM

We are also seeing this crash in prod after bumping to 1.7+

gr...@google.com <gr...@google.com> #5Dec 2, 2024 07:24PM

#1 - could you attach a sample if you can reproduce this consistently?

gr...@google.com <gr...@google.com> #6Dec 4, 2024 12:42AM

The fix I made was for b/350534714, which is fixed in 1.7.3

gr...@google.com <gr...@google.com> #7Dec 4, 2024 12:42AM

Reassigned to bu...@google.com.

I'm also seeing this crash after update compose to 1.7.4

ap...@google.com <ap...@google.com> #8Dec 4, 2024 12:42AM

Marked as fixed.

edenman@x.com: can you please share a code snippet to reproduce the crash?

gr...@google.com <gr...@google.com> Dec 4, 2024 12:43AM

Status: Assigned (reopened)

bu...@google.com <bu...@google.com> #9Dec 4, 2024 12:43AM

Accepted by bu...@google.com.

We were never able to figure out a simple repro case, sorry. Maybe @feenixspz has one?

(our workaround was to try/catch in our base Activity's dispatchKeyEvent and return false if something throws)

gr...@google.com <gr...@google.com> #10Dec 4, 2024 12:43AM

Assigned to bu...@google.com.

Please check my example. I reproduced the crash in my pixel 6a 14. Click the edit text and then click the keyboard done.

bu...@google.com <bu...@google.com> #11Dec 4, 2024 12:43AM

Accepted by bu...@google.com.

George, would you mind checking the example in #comment10 to confirm whether your fix addresses the issue?

gr...@google.com <gr...@google.com> #12Dec 11, 2024 10:11PM

Marked as fixed, reassigned to gr...@google.com.

We're running into this as well after bumping to 1.7.0. Updating to 1.7.3 didn't resolve the issue.

si...@gmail.com <si...@gmail.com> #13Dec 12, 2024 09:22AM

I am able to repro with the given project.

gr...@google.com <gr...@google.com> #14Dec 12, 2024 05:51PM

Verified by gr...@google.com.

The problem is that ComposeView assumes that its contents are focusable. As a work-around, I think that if you call view.focusable = false after instantiation, you won't have this problem.