kotlin android.os.Handler removeCallbacks Runnable [376498180]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Oct 31, 2024 06:24AM

kotlin always let ()->Unit as Runnable. But android Handler cannot removeCallbacks. Ex:

    private val connectRunnable:()->Unit = {
        //xxxx
    }

    fun test() {
        handler.postDelayed(connectRunnable, 100)
        handler.removeCallbacks(connectRunnable)
    }

Above code will be compiled into:

   public final void test() {
      Function0 var1 = this.connectRunnable;
      this.handler.postDelayed(A::test$lambda$0, 100L);
      var1 = this.connectRunnable;
      this.handler.removeCallbacks(A::test$lambda$1); //diff from postDelay
   }

   private static final void test$lambda$0(Function0 $tmp0) {
      Intrinsics.checkNotNullParameter($tmp0, "$tmp0");
      $tmp0.invoke();
   }

   private static final void test$lambda$1(Function0 $tmp0) {
      Intrinsics.checkNotNullParameter($tmp0, "$tmp0");
      $tmp0.invoke();
   }

The ()->Unit function has be wrapped by diff lambda, it's not same one. So, the android Handler can't removeCallback.

We have to replace with Runnable statement.

Could you please add some warning message just like SharedPreferences' commit() to removeCallback when using kotlin?

deleted

Restricted

0 B

deleted

Restricted

0 B

Comments

gg...@google.com <gg...@google.com> #2Oct 31, 2024 11:23PM

Assigned to vi...@google.com.

This can be either an issue with interface method desugaring, most likely one of the dependency has now new static/default/private methods on interfaces which is incorrectly supported by our compiler, or it's an issue with desugared library, or both.

To rule the options out:
- Are you using desugared library in your project (

https://developer.android.com/studio/write/java8-support-table)?
- What is the minSdk of your project? If it's strictly below 24, and you change it to 24, and let us know if the issue happens.

If you want us to help you further, for example by helping you build a work-around, or fix the compiler, we need you to either provide us a reproduction project (github or zip) or a compilation dump of your application (See how to generate dumps here

https://r8.googlesource.com/r8/+/refs/heads/main/doc/compilerdump.md).

Thanks for the report.

vi...@google.com <vi...@google.com> #3Nov 10, 2024 06:57AM

Yes, I'm using desugaring, version 1.2.2 (to work with LocalDate). I tried to build a signed apk with disabled desugaring and the build was successful.
In my project minSdk is 24.

Unfortunately I can't provide you the source code or dump as this is a confidential project, but I can provide a list of dependencies, build.gradle files and a class that works with LocalDate if that helps, or maybe smth else, but not a whole project(

al...@gmail.com <al...@gmail.com> #4Nov 11, 2024 02:39AM

This is also asked on Stack Overflow: https://stackoverflow.com/questions/75162303/r8-minifyreleasewithr8-failed-attempt-to-enqueue-an-action-in-a-non-pushable-en

ra...@google.com <ra...@google.com> Nov 13, 2024 11:46PM

Reassigned to an...@google.com.

pa...@google.com <pa...@google.com> Nov 14, 2024 01:23PM

Status: New

tn...@google.com <tn...@google.com> #5Nov 19, 2024 12:58AM

Marked as fixed, reassigned to tn...@google.com.

Retracing from Stack overflow gives:

Caused by: com.android.tools.r8.errors.Unreachable: Attempt to enqueue an action in a non pushable enqueuer work list.
    at com.android.tools.r8.shaking.EnqueuerWorklist$NonPushableEnqueuerWorklist.attemptToEnqueue(EnqueuerWorklist.java:800)
    at com.android.tools.r8.shaking.EnqueuerWorklist$NonPushableEnqueuerWorklist.enqueueMarkMethodLiveAction(EnqueuerWorklist.java:856)
    at com.android.tools.r8.shaking.Enqueuer.markMethodAsLiveWithCompatRule(Enqueuer.java:4882)
    at com.android.tools.r8.shaking.Enqueuer.markMethodAsTargeted(Enqueuer.java:4773)
    at com.android.tools.r8.shaking.Enqueuer.lambda$markVirtualMethodAsReachable$88(Enqueuer.java:3387)
    at com.android.tools.r8.graph.MethodResolutionResult$SingleProgramResolutionResult.visitMethodResolutionResults(MethodResolutionResult.java:897)
    at com.android.tools.r8.graph.MethodResolutionResult.forEachMethodResolutionResult(MethodResolutionResult.java:103)
    at com.android.tools.r8.shaking.Enqueuer.markVirtualMethodAsReachable(Enqueuer.java:3340)
    at com.android.tools.r8.shaking.Enqueuer.traceInvokeInterface(Enqueuer.java:1463)
    at com.android.tools.r8.shaking.Enqueuer.traceInvokeInterface(Enqueuer.java:1447)
    at com.android.tools.r8.shaking.DefaultEnqueuerUseRegistry.registerInvokeInterface(DefaultEnqueuerUseRegistry.java:86)
    at com.android.tools.r8.cf.code.CfInvoke.internalRegisterUse(CfInvoke.java:153)
    at com.android.tools.r8.cf.code.CfInstruction.registerUse(CfInstruction.java:104)
    at com.android.tools.r8.graph.CfCode.registerCodeReferences(CfCode.java:683)
    at com.android.tools.r8.graph.ProgramMethod.registerCodeReferences(ProgramMethod.java:127)
    at com.android.tools.r8.shaking.Enqueuer.traceCode(Enqueuer.java:4809)
    at com.android.tools.r8.shaking.Enqueuer.traceNonDesugaredCode(Enqueuer.java:4803)
    at com.android.tools.r8.shaking.Enqueuer.markMethodAsLive(Enqueuer.java:4742)
    at com.android.tools.r8.shaking.EnqueuerWorklist$MarkMethodLiveAction.run(EnqueuerWorklist.java:166)
    at com.android.tools.r8.shaking.Enqueuer.postProcessingDesugaring(Enqueuer.java:4540)
    at com.android.tools.r8.shaking.Enqueuer.trace(Enqueuer.java:4477)
    at com.android.tools.r8.shaking.Enqueuer.traceApplication(Enqueuer.java:3622)
    at com.android.tools.r8.R8.runEnqueuer(R8.java:1012)
    at com.android.tools.r8.R8.run(R8.java:369)
    at com.android.tools.r8.R8.run(R8.java:252)
    at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
    at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)
    ... 34 more

an...@google.com <an...@google.com> #6Nov 22, 2024 12:04AM

This comes from the desugaring post processing. It could be:

desugared library retargeting
~~interface method desugaring~~ (not in 1.2 with 24)
api callback
~~record~~ (not generating methods)
~~disable desugarer~~ (not generating method)

What's going on is that R8 is verifying that code generated in the post processor is targeting already traced code.

Is there in the app any override of the following 3 methods: [java.time.ZoneId java.util.TimeZone.toZoneId(), java.time.ZonedDateTime java.util.GregorianCalendar.toZonedDateTime(), java.time.Instant java.util.Date.toInstant()] ?

Alternatively, it could be that something not traced as a library override is now traced with the callback? @mkroghj wasn't there a change on library override computation and tracing?