constraintlayout-core 1.1.0 breaks binary compatibility with 1.0.4 [376718273]

Fixed

Bug

Status Update

No update yet.

Description

ca...@careem.com

created issue #1

Nov 1, 2024 11:22AM

ConstraintLayout Core version: 1.1.0

Bumping constraintlayout-core to 1.1.0 from 1.0.4 I got runtime exceptions due to binary incompatibilities between the two versions.

In particular I see incompatibilities with the `androidx.constraintlayout.core.state.Dimension` class.

For example the core version bundled with constraintlayout 2.1.4 (core-1.0.4) had the method `public static Dimension Fixed(int value)` which now is not available anymore (renamed to `public static Dimension createFixed(int value)` ?)

https://github.com/androidx/constraintlayout/blob/53a933633d84508d3a00a534c846b1af5a19fcd3/constraintlayout/core/src/main/java/androidx/constraintlayout/core/state/Dimension.java#L82

Here is the commit that broke incompatibility for the case above:

https://github.com/androidx/constraintlayout/commit/fa5ce40122639f9e83722548a4adb510a24fb509#diff-d12dd4713639b1049b7636ae8fbb9145acd8e5906115d1f3a1048d63df3bb646L101

Would it be possible to restore compatibility in the new core so we are able to update?

Comments

al...@google.com <al...@google.com> #2Nov 18, 2024 08:10PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ys...@google.com <ys...@google.com> #3Dec 4, 2024 10:50AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ca...@careem.com <ca...@careem.com> #4Jan 7, 2025 06:16PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ca...@careem.com <ca...@careem.com> #5Jan 8, 2025 10:19AM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ca...@careem.com <ca...@careem.com> #6Jan 8, 2025 11:25AM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

ho...@google.com <ho...@google.com> Jan 8, 2025 04:11PM

Reassigned to os...@google.com.

os...@google.com <os...@google.com> Jan 18, 2025 12:24AM

Reassigned to os...@google.com.

os...@google.com <os...@google.com> #7Mar 3, 2025 05:09PM

Marked as fixed.

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!