WebViewFeature.isFeatureSupported does not support WebViewFeature.WEB_AUTHENTICATION [377161959]

Fixed

Bug

Status Update

No update yet.

Description

so...@gmail.com

created issue #1

Nov 4, 2024 07:41AM

Component used: androidx.webkit
Version used: 1.12.1
Devices/Android versions reproduced on:

I want to use PassKey.
Looking at the guide, it seems like I should check the code below first and then call setWebAuthenticationSupport().

WebViewFeature.isFeatureSupported(WebViewFeature.WEB_AUTHENTICATION)

Since WEB_AUTHENTICATION is not registered as an Enum in WebViewFeature, it is not entered as a parameter in isFeatureSupported.

Is this scheduled for a future fix? Or is it okay not to use isFeatureSupported()?

Comments

nt...@google.com <nt...@google.com> #2Nov 4, 2024 05:56PM

Reassigned to el...@google.com.

Sayed can you look at this and advise? Is this just an issue of out of date WebView?

nt...@google.com <nt...@google.com> #3Nov 4, 2024 05:58PM

Since WEB_AUTHENTICATION is not registered as an Enum in WebViewFeature, it is not entered as a parameter in isFeatureSupported.

Sounds like it might be an StringDef bug on our end. Did we forget to add a constant to the StringDef list? https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java;l=56;drc=8dc7986f686d4f65b75ca5842b465d59cc7d02f3

CC pbirk@ since this might impact other webkit library features.

el...@google.com <el...@google.com> #4Nov 4, 2024 06:21PM

Yea, It seems we missed adding the StringDef, which will cause a lint warning.

@reporter, you can still use WebViewFeature.isFeatureSupported(WebViewFeature.WEB_AUTHENTICATION) and either ignore the lint error or suppress it while we work on a fix. Please don’t skip using isFeatureSupported.

ap...@google.com <ap...@google.com> #5Nov 13, 2024 09:48AM

Project: platform/frameworks/support
Branch: androidx-main
Author: elabadysayed <elabadysayed@google.com>
Link: https://android-review.googlesource.com/3344784

Add missing StringDef for WEB_AUTHENTICATION

Expand for full commit details

Add missing StringDef for WEB_AUTHENTICATION 
 
@StringDef for WEB_AUTHENTICATION was missing in  WebViewFeature which will cause a lint warning while trying to use. 
 
 
Test: N/A 
Bug: 377161959 
Change-Id: I5a472f17b6f6ae8ed2a266bb42d01db69acf1325

Files:

M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java

Hash: a402966a281126e9197ff9cdfe0b6bb84ab0a57a
Date: Tue Nov 12 11:39:19 2024

el...@google.com <el...@google.com> #6Nov 13, 2024 10:24AM

Marked as fixed.

The fix will be available from 1.13.0-alpha02.

pr...@google.com <pr...@google.com> #7Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.webkit:webkit:1.13.0-alpha02

Issue 377161959