IssueTracker

This appears to have regressed in Iguana.

We added the @Language("sql") API functionality in macrobench in this change: https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2447462

So as of March 6 last year, it was working as I developed that change. I tried a few versions of Studio to narrow this regression down:

• Electric eel (not working, presumably not supported yet)
• Flamingo (works in basic way, see 1st screenshot) - I expect AndroidX would have been on a Flamingo canary when I added the annotation
• Giraffe (works)
• Hedgehog (works better, see 2nd screenshot which now highlights the table name as a standard identifier)
• Iguana (broken in current way, see 3rd screenshot)

I tested by creating a trivial empty project, and adding the following to the example unit test:

    fun sql(@Language("sql") param: String) {}
    @Test
    fun foo() {
        sql("select * from whatever")
    }

Paste containing exact versions I tested on (these are just the initial stable versions of each release): https://paste.googleplex.com/4747774884315136

The above shows the string as a syntax error, when in reality we should just be displaying it as a normal string without any syntax highlighting

That has been fixed. DeviceSpecInjector should only be applied for @Preview annotations. The scenario from comment #5 is displayed as a normal string (no syntax error) now: http://screen/3aNg9znY8dG3v4Y.png

That's better, but if it's just displayed as a string, it's still a regression from Flamingo, see #comment5

Can we get that @Language("sql") support added back to Studio?

Can we get that @Language("sql") support added back to Studio?

Would using @Language("RoomSql") work for your use case? Otherwise I'll file a feature request to the core editor team to add support for @Language("sql") and we can follow up there. I'd leave this bug focused on the issue originally reported (syntax error), which was caused by our custom device spec.

This is how the snippet from https://r.android.com/c/platform/frameworks/support/+/2447462/7/benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/AudioUnderrunQuery.kt#29 looks like when using @Language("RoomSql") (see attachment)

Marking this as fixed per comment #8. Filed issue 400745325 to follow up about restoring support of @Language("sql") if this is still needed.

Would using @Language("RoomSql") work for your use case

Unfortunately no, "RoomSql" doesn't support includes or function declarations in my testing (see screenshots, where this worked with @Language("sql") in Giraffe, but has red squigglies in Meerkat FD Canary 7). Samples of the syntax our library's clients will call here.