WrongConstant lint on definition instead of usage of constant using shift [378128668]

Fixed

Bug

Status Update

No update yet.

Description

ju...@google.com

created issue #1

Nov 8, 2024 08:20PM

Seeing this when trying to update AndroidX to lint 31.8.0-alpha08 from 31.8.0-alpha06. Assuming this is related to b/370778975.

When an incorrect constant is used for an IntDef, and the constant was defined using the int shift operator, the lint error is appearing on the constant definition instead of the usage.

Repro example:

import androidx.annotation.IntDef;

public class TestFlags {
    public static final int SHIFT_FLAG = 1 << 1;

    @IntDef(flag = true, value = { 0 })
    public @interface FlagDef {}

    @FlagDef int flags = SHIFT_FLAG;
}

Instead of a lint error appearing on the flags = SHIFT_FLAG line, it instead appears on the definition of SHIFT_FLAG:

  TestFlags.java:22: Error: Must be one or more of: 0 [WrongConstant]
      public static final int SHIFT_FLAG = 1 << 1;
                                           ~
  TestFlags.java:22: Error: Must be one or more of: 0 [WrongConstant]
      public static final int SHIFT_FLAG = 1 << 1;
                                                ~

Comments

js...@google.com <js...@google.com> #2Nov 8, 2024 08:27PM

Bingran, can you please take a look?

From the stacktrace, it seems like the issue is triggered during the native model building (com.android.build.gradle.internal.ide.v2.NativeModelBuilder.buildAll(NativeModelBuilder.kt:104), and it seems like .kts build files are used (see prepareKotlinBuildScriptModel task running).

Nick, does using:

Android Studio: 2021.3.1 Canary 7
AGP: 7.1.2
Gradle: 7.2

also fail?

ju...@google.com <ju...@google.com> #3Nov 8, 2024 08:31PM

I can't seem to reproduce the error now, but that may be due to project changes, or perhaps cache invalidation etc fixed it. However, given the error, perhaps there is still a bug there.

I only use build.gradle files, not kts, so any kotlin build files would be internal. However, the app uses Kotlin.

Gradle 7.2 worked with AGP 7.1.2, just 7.4 that had the problem.

js...@google.com <js...@google.com> #4Nov 8, 2024 09:21PM

The error is thrown when analytics is queried in NativeModelBuilder but AnalyticsService doesn't seem to have been configured which is the reason why we get "no value available" error from AnalyticsService.reconstructProfileBuilder(AnalyticsService.kt:199. Is is not obvious why AnalyticsService is not configured in a sync build. Due to it cannot be reproduced consistently, I think we should downgrade the priority and upgrade it when we see similar issues.

js...@google.com <js...@google.com> Nov 13, 2024 07:08PM

Accepted by js...@google.com.

js...@google.com <js...@google.com> Nov 17, 2024 07:11PM

Marked as fixed.

an...@google.com <an...@google.com> #5Nov 22, 2024 12:04AM

I am running into this error again. Gradle 7.4 or 7.3.3, AGP 7.2.0, AS Dolphin | 2021.3.1 Beta 1. What can I try to resolve it?

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

Does it happen consistently? like every time you open the project?