WrongConstant lint on definition instead of usage of constant using shift [378128668]

Fixed

Bug

Status Update

No update yet.

Description

ju...@google.com

created issue #1

Nov 8, 2024 08:20PM

Seeing this when trying to update AndroidX to lint 31.8.0-alpha08 from 31.8.0-alpha06. Assuming this is related to b/370778975.

When an incorrect constant is used for an IntDef, and the constant was defined using the int shift operator, the lint error is appearing on the constant definition instead of the usage.

Repro example:

import androidx.annotation.IntDef;

public class TestFlags {
    public static final int SHIFT_FLAG = 1 << 1;

    @IntDef(flag = true, value = { 0 })
    public @interface FlagDef {}

    @FlagDef int flags = SHIFT_FLAG;
}

Instead of a lint error appearing on the flags = SHIFT_FLAG line, it instead appears on the definition of SHIFT_FLAG:

  TestFlags.java:22: Error: Must be one or more of: 0 [WrongConstant]
      public static final int SHIFT_FLAG = 1 << 1;
                                           ~
  TestFlags.java:22: Error: Must be one or more of: 0 [WrongConstant]
      public static final int SHIFT_FLAG = 1 << 1;
                                                ~

Comments

js...@google.com <js...@google.com> #2Nov 8, 2024 08:27PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Are you reporting this as a Developer or User?
Please confirm if you are using any third party application as a launcher?
Could you please provide a screen record of the issue for us to further investigate?

Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.

ju...@google.com <ju...@google.com> #3Nov 8, 2024 08:31PM

I am a User
No third party launcher using Default pixel launcher
I cannot for now recreate the bug but will enable screen record and upload when caught

js...@google.com <js...@google.com> #4Nov 8, 2024 09:21PM

Thank you for your response.

Once you are able to reproduce this bug, please upload the screen record of the issue.

js...@google.com <js...@google.com> Nov 13, 2024 07:08PM

Accepted by js...@google.com.

js...@google.com <js...@google.com> Nov 17, 2024 07:11PM

Marked as fixed.

an...@google.com <an...@google.com> #5Nov 22, 2024 12:04AM

Please upgrade to the latest release from the link Beta2.1.

If the issue still persists, please capture the new bug report along with the screen record and share it here.

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.