Status Update
No update yet.
Comments
ma...@google.com
je...@google.com
ka...@google.com
Realized this also affects effectively-sealed classes (no public or protected constructors). We should consider adding ClassItem.isEffectivelySealed() to match.
We have three options for the logic:
- Search
Codebasefor all descendent classes of each effectively sealed class and only consider the ancestor class effectively final if all its descendents are concrete or effectively sealed. This matches the behavior inherent to the language. - Disallow sealed (possibly also effectively sealed) classes from having abstract descendents altogether. This limits some potentially valid APIs (E.g.: ADT that the client extends) but might be worth doing if we think this is a bad API pattern.
- Disallow adding abstract methods to any abstract class or interface altogether. This checks is the only exception to rule against adding abstract methods, and maybe it's better to never add abstract methods to existing public classes.
da...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <
Link:
Revert^2 "Add requestFocus(FocusDirection) to focusRequester"
Expand for full commit details
Revert^2 "Add requestFocus(FocusDirection) to focusRequester"
This reverts commit 274c9242bfe89dad5aeb7179750d45fa64c6ab80.
Reason for revert: The original CL was correct. The revert was incorrect.
Relnote: "Adds requestFocus(FocusDirection) to both focusRequester and
FocusTargetModifierNode to allow focusing with a specific
direction."
Bug: 220960090
Test: new test
Change-Id: I96b97720a65d2e1bf8d7f845dc05844f7e7f565c
Files:
- M
compose/ui/ui/api/1.8.0-beta01.txt - M
compose/ui/ui/api/current.ignore - M
compose/ui/ui/api/current.txt - M
compose/ui/ui/api/restricted_1.8.0-beta01.txt - M
compose/ui/ui/api/restricted_current.ignore - M
compose/ui/ui/api/restricted_current.txt - M
compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/ExplicitEnterExitWithCustomFocusEnterExitDemo.kt - M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt - M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOwnerImpl.kt - M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt - M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetModifierNode.kt - M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetNode.kt - M
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTransactions.kt
Hash: fb5d4a3eebdbc0cd3034d11eae8e00f507ec1a68
Date: Wed Nov 06 19:23:12 2024
xa...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: drchen <
Link:
Introduce APIs to support pane preferred heights
Expand for full commit details
Introduce APIs to support pane preferred heights
Note that we need to ignore API checking of adding the modifier
to PaneScaffoldScope, as b/220960090 indicates, the current Metalava
is not able to tell if a sealed interface has been implemented by
an open abstract class. (In our case, all inheritances are sealed or
internal so we are good to ignore the API warning.)
Relnote: "Introduce PaneScaffoldScope.preferredHeight modifier for
devs to provide pane preferred heights that will be applied with
new adapt strategies we are going to introduce."
Test: n/a
Bug: 373490181
Bug: 373489847
Change-Id: I957dd252b2bd154e3b0be048c092147fb6d1b2b8
Files:
- M
compose/material3/adaptive/adaptive-layout/api/current.ignore - M
compose/material3/adaptive/adaptive-layout/api/current.txt - M
compose/material3/adaptive/adaptive-layout/api/restricted_current.ignore - M
compose/material3/adaptive/adaptive-layout/api/restricted_current.txt - M
compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/PaneScaffold.kt - M
compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/PaneScaffoldDirective.kt
Hash: 0d7a940f0ce81b2a9a699146f48de72a177357b7
Date: Wed Feb 26 11:34:20 2025
pe...@gmail.com
I have to rebuild / clean the project sometimes. Hilt/Dagger sometimes just fails to build. Probably due to external git checkout.
to...@gmail.com
I'm using it also daily, it is the only way how to fix build-cache issues, KSP cache issues, or any other cache issue.
xa...@google.com
if you have a build cache issue (as in a cache entry is wrong), doing a clean will not fix it, since the task will just grab the content from the cache. You'd need to run with --rerun-tasks to force running the task and ignore the cache entry. This is not done by the rebuild action of Studio.
ka...@google.com
This will also be added back in the Meerkat Version 2024.3.1 starting from Canary 3.
an...@google.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Meerkat | 2024.3.1 Canary 3
- Android Gradle Plugin 8.9.0-alpha03
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
Description
####################################################
Please provide all of the following information, otherwise we may not be able to route your bug report.
####################################################
1. Describe the bug or issue that you're seeing.
Android Studio Ladybug Feature Drop 2024.2.2 Canary 9 does not have the "Clean build" menu option under Build in menubar. This is available in Ladybyg 2024.2.1 Patch 2. I have attached screenshots.
2. Attach log files from Android Studio
2A. In the IDE, select the Help..Collect Logs and Diagnostic Data menu option.
2B. Create a diagnostic report and save it to your local computer.
2C. Attach the report to this bug using the Add attachments button.
3. If you know what they are, write the steps to reproduce:
3A. "Build" > "Clean build" is missing. This is available in 2024.2.1 Patch 2
In addition to logs, please attach a screenshot or recording that illustrates the problem.
For more information on how to get your bug routed quickly, see
Build: AI-242.23339.11.2422.12584204, 202410311828
AS: Ladybug Feature Drop | 2024.2.2 Canary 9
AI-242.23339.11.2422.12584204, JRE 21.0.4+13-b509.17x64 JetBrains s.r.o., OS Mac OS X(aarch64) v14.7, screens 3600x2338 (200%); Retina
Android Gradle Plugin: 8.7.2
Gradle: 8.10.2
Gradle JDK: JetBrains Runtime 21.0.4 - aarch64
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
```