Obsolete

Feature

Status Update

No update yet.

Description

mg...@google.com

created issue #1

Nov 13, 2024 05:26PM

While saveable depends on a Saver implementation, saved depends on a KSerializer. Both are valid options, depending on project needs (e.g., adding a KotlinX Serialization dependency might be undesirable).

To smooth the transition between these APIs, we want to enable using Saver as a KSerializer and vice versa.

This would allow using Serializable classes in saveable, and Saveable data in saved.

Since Saver returns a type accepted by Bundle, and encodeToSavedState returns a Bundle, we can theoretically wrap one within the other for compatibility with both APIs at the cost of an wrapper instance.

The goal is to determine the best way to handle this interoperability.

Comments

va...@google.com <va...@google.com> #2Nov 25, 2024 04:32PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3506351

Clean-up SavedState Serialization Reified functions

Expand for full commit details

Clean-up SavedState Serialization Reified functions 
 
- Ensure their positioning and "call hierarchy" match each other. 
- Make the KDocs consistent with KTX Serialization. 
 
RelNote: "N/A" 
Bug: b/399629301 
Test: N/A 
Change-Id: Icb6924b6f1929d4a3c00ded922c74e83fbe163f1

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt

Hash: 4f4e3cf53813a572ddd78967a279e9d5415ac615
Date: Mon Feb 24 13:54:34 2025

mg...@google.com <mg...@google.com> #3Jan 17, 2025 04:27PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3517474

Rename file SavedStateDelegates to SavedStateDelegate

Expand for full commit details

Rename file SavedState*Delegates to SavedState*Delegate 
 
- File name now matches the class name `SavedState*Delegate`. 
- That is consistent with `SavedStateDecoder.kt` and `SavedStateEncoder.kt` that are named after the `internal class` but expose only top-level functions (`SavedStateDecoderKt.method()` or `SavedStateEncoderKt.method()`). 
 
RelNote: "Rename `SavedState*Delegates` to `SavedState*Delegate`." 
Bug: 399629301 
Test: N/A 
Change-Id: I8589b62294646cb4529869228ea0185dac6087e6

Files:

M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegateTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegate.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegate.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegateTest.kt

Hash: d749bb5032edfe9547da480963da3c559b874023
Date: Fri Feb 28 14:18:38 2025

Message last modified on Jan 17, 2025 04:27PM

mg...@google.com <mg...@google.com> #4Jan 22, 2025 06:03PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3506352

Rename SavedStateConfig to SavedStateConfiguration

Expand for full commit details

Rename SavedStateConfig to SavedStateConfiguration 
 
- Previously called `SavedStateConfig`, we have decide to match the name used by the other KotlinX Serialization format configs. 
 
RelNote: "Rename `SavedStateConfig` to `SavedStateConfiguration`." 
Bug: 399629301 
Test: N/A 
Change-Id: I043a5be95276ef617588559f5e3fcdb15905b793

Files:

M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegatesTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
M savedstate/savedstate-compose/src/androidInstrumentedTest/kotlin/androidx/savedstate/compose/serialization/serializers/MutableStateSerializerTest.android.kt
M savedstate/savedstate-samples/src/main/java/androidx/savedstate/SavedStateCodecSamples.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/ClassDiscriminatorMode.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateConfiguration.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTestUtils.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/MutableStateFlowSerializerTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorAllObjectsTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorPolymorphicTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecEncodeDefaultsTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegatesTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/utils/SavedStateSerializationBaseTest.kt

Hash: db71d74194b21d66c591aebfa5b6ea0398f0cd51
Date: Mon Feb 24 14:33:00 2025

Message last modified on Jan 23, 2025 11:18AM

mg...@google.com <mg...@google.com> Feb 6, 2025 02:55PM

Reassigned to ku...@google.com.

ap...@google.com <ap...@google.com> #5Feb 18, 2025 05:10PM

Android API Change

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council regularly reviews API changes for consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.

We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.

Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt

androidx.lifecycle.serialization
androidx.lifecycle.serialization.SavedStateHandleDelegateKt
androidx.lifecycle.serialization.SavedStateHandleDelegatesKt

Changes to savedstate/savedstate/api/current.txt

androidx.savedstate.serialization
androidx.savedstate.serialization.SavedStateRegistryOwnerDelegateKt
androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt

http://go/agw/platform/frameworks/support/+/d749bb5032edfe9547da480963da3c559b874023%5E%21
https://android-review.googlesource.com/3517474

[Gerrit:https://android-review.googlesource.com/3517474]
[API-Approvers:ilake@google.com]
[Branch:androidx-main]

[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]

mg...@google.com <mg...@google.com> Feb 24, 2025 12:01PM

Accepted by mg...@google.com.

mg...@google.com <mg...@google.com> #6Apr 10, 2025 10:47AM

Status: Won't Fix (Obsolete)

Android API Change

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council regularly reviews API changes for consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.

We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.

Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt

androidx.lifecycle.serialization
androidx.lifecycle.serialization.SavedStateHandleDelegatesKt

Changes to savedstate/savedstate/api/current.txt

androidx.savedstate.serialization
androidx.savedstate.serialization.SavedStateConfig
androidx.savedstate.serialization.SavedStateConfig.Builder
androidx.savedstate.serialization.SavedStateConfig.Companion
androidx.savedstate.serialization.SavedStateConfigKt
androidx.savedstate.serialization.SavedStateConfiguration
androidx.savedstate.serialization.SavedStateConfiguration.Builder
androidx.savedstate.serialization.SavedStateConfiguration.Companion
androidx.savedstate.serialization.SavedStateConfigurationKt
androidx.savedstate.serialization.SavedStateDecoderKt
androidx.savedstate.serialization.SavedStateEncoderKt
androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt

http://go/agw/platform/frameworks/support/+/db71d74194b21d66c591aebfa5b6ea0398f0cd51%5E%21
https://android-review.googlesource.com/3506352

[Gerrit:https://android-review.googlesource.com/3506352]
[API-Approvers:ilake@google.com]
[Branch:androidx-main]

[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]

Message last modified on Apr 10, 2025 10:52AM

na...@google.com <na...@google.com> #7Apr 23, 2025 10:24PM

Android API Change

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council regularly reviews API changes for consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.

We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.

Changes to savedstate/savedstate/api/current.txt

androidx.savedstate.serialization
androidx.savedstate.serialization.SavedStateDecoderKt
androidx.savedstate.serialization.SavedStateEncoderKt

http://go/agw/platform/frameworks/support/+/4f4e3cf53813a572ddd78967a279e9d5415ac615%5E%21
https://android-review.googlesource.com/3506351

[Gerrit:https://android-review.googlesource.com/3506351]
[API-Approvers:ilake@google.com]
[Branch:androidx-main]

[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]

IssueTracker

[Serialization] `KSerializer` and `Saver` interoperability

Status Update

Description

Comments

va...@google.com <va...@google.com> #2Nov 25, 2024 04:32PM

mg...@google.com <mg...@google.com> #3Jan 17, 2025 04:27PM

mg...@google.com <mg...@google.com> #4Jan 22, 2025 06:03PM

mg...@google.com <mg...@google.com> Feb 6, 2025 02:55PM

ap...@google.com <ap...@google.com> #5Feb 18, 2025 05:10PM

Android API Change

mg...@google.com <mg...@google.com> Feb 24, 2025 12:01PM

mg...@google.com <mg...@google.com> #6Apr 10, 2025 10:47AM

Android API Change

na...@google.com <na...@google.com> #7Apr 23, 2025 10:24PM

Android API Change

Issue 378897438

Description

Issue summary

Comments

va...@google.com <va...@google.com> #2Nov 25, 2024 04:32PM

mg...@google.com <mg...@google.com> #3Jan 17, 2025 04:27PM

mg...@google.com <mg...@google.com> #4Jan 22, 2025 06:03PM

mg...@google.com <mg...@google.com> Feb 6, 2025 02:55PM

ap...@google.com <ap...@google.com> #5Feb 18, 2025 05:10PM

Android API Change

mg...@google.com <mg...@google.com> Feb 24, 2025 12:01PM

mg...@google.com <mg...@google.com> #6Apr 10, 2025 10:47AM

Android API Change

na...@google.com <na...@google.com> #7Apr 23, 2025 10:24PM

Android API Change

Add comment

Issue metadata