[Serialization] `KSerializer` and `Saver` interoperability [378897438]

In Progress

Feature

Status Update

No update yet.

Description

mg...@google.com

created issue #1

Nov 13, 2024 05:26PM

While saveable depends on a Saver implementation, saved depends on a KSerializer. Both are valid options, depending on project needs (e.g., adding a KotlinX Serialization dependency might be undesirable).

To smooth the transition between these APIs, we want to enable using Saver as a KSerializer and vice versa.

This would allow using Serializable classes in saveable, and Saveable data in saved.

Since Saver returns a type accepted by Bundle, and encodeToSavedState returns a Bundle, we can theoretically wrap one within the other for compatibility with both APIs at the cost of an wrapper instance.

The goal is to determine the best way to handle this interoperability.

Comments

va...@google.com <va...@google.com> #2Nov 25, 2024 04:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

mg...@google.com <mg...@google.com> #3Jan 17, 2025 04:27PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Message last modified on Jan 17, 2025 04:27PM

mg...@google.com <mg...@google.com> #4Jan 22, 2025 06:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Message last modified on Jan 23, 2025 11:18AM

mg...@google.com <mg...@google.com> Feb 6, 2025 02:55PM

Reassigned to ku...@google.com.

ap...@google.com <ap...@google.com> #5Feb 18, 2025 05:10PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3497596

Expose SavedStateConfig properties as public

Expand for full commit details

Expose `SavedStateConfig` properties as public 
 
- We have cases where `SavedStateConfig` properties need to be used in other modules, such as handling fallbacks with `serializersModule.serializer()` to support contextual and polymorphic serializers. 
- To follow KTX Serialization convention, we are keeping `SavedStateConfig` properties public, similar to how `JsonConfiguration` does. 
 
RelNote: "`SavedStateConfig` properties are now public, enabling other modules to use these configurations." 
Bug: 378897438 
Test: N/A 
Change-Id: Ie5f4997bc61932de390da3699339e01b2e91b514

Files:

M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateConfig.kt

Hash: ec92c9e6c519cd5c3b3ea54ea523e4b7dc2a15dc
Date: Tue Feb 18 14:27:58 2025

mg...@google.com <mg...@google.com> Feb 24, 2025 12:01PM

Accepted by mg...@google.com.

Issue 378897438