IssueTracker

Component used: Credentials

Version used: 1.3.0, 1.5.0-beta01, GoogleId 1.1.1

Devices/Android versions reproduced on: Xiaomi POCO X4 Pro 5G (API level 33), Emulator (API level 35)

If this is a bug in the library, we would appreciate if you could attach:

• Sample project to trigger the issue.
• A screenrecord or screenshots showing the issue (if UI related).

I have the following code used to instantiate a GetSignInWithGoogleOption:

package <app>.core.auth.credentials

import android.content.Context
import com.google.android.libraries.identity.googleid.GetSignInWithGoogleOption
import java.util.UUID
import <app>.core.auth.gms.R as GmsR

val Context.googleBtnOption: GetSignInWithGoogleOption
    get() = GetSignInWithGoogleOption(
        serverClientId = getString(GmsR.string.default_web_client_id),
        nonce = UUID.randomUUID().toString()
    )

And the code used to sign in with Google which integrates with Firebase Authentication:

suspend fun @receiver:UiContext Context.requestGoogleCredential(
    credentialOptions: List<CredentialOption>
): GoogleIdTokenCredential {
    val getCredentialRequest = GetCredentialRequest(credentialOptions = credentialOptions)

    val credentialManager = CredentialManager.create(this)

    val getCredentialResponse = credentialManager.getCredential(
        context = this,
        request = getCredentialRequest
    )

    return when (val credential = getCredentialResponse.credential) {
        is GoogleIdTokenCredential -> credential

        is CustomCredential -> when (credential.type) {
            GoogleIdTokenCredential.TYPE_GOOGLE_ID_TOKEN_CREDENTIAL -> {
                GoogleIdTokenCredential.createFrom(credential.data)
            }

            else -> throw UnsupportedOperationException()
        }

        else -> throw UnsupportedOperationException()
    }
}

suspend fun FirebaseAuth.signInWithGoogleCredentials(
    context: Context,
    credentialOptions: List<CredentialOption>
): AuthResult {
    val cred = context.requestGoogleCredential(credentialOptions)

    return signInWithGoogleAsync(cred)
}

And the code which calls the sign in method:

private fun signInWithGoogle() {
    lifecycleScope.launch {
        try {
            auth.signInWithGoogleCredentials(
                this@LoginActivity,
                listOf(googleBtnOption)
            )
        } catch (e: GetCredentialException) {
            Log.w(TAG, "Could not get credentials:", e)
            showToast(e.errorMessage!!, Toast.LENGTH_LONG)
        }
    }
}

This results in a runtime NoSuchMethodError being shown when the signInWithGoogle method is called:

java.lang.NoSuchMethodError: No direct method <init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V in class Lcom/google/android/libraries/identity/googleid/GetSignInWithGoogleOption; or its super classes (declaration of 'com.google.android.libraries.identity.googleid.GetSignInWithGoogleOption' appears in /data/app/~~Z6vTajOwuF4V1TyH39AMsg==/<app>-GhGfVigQLhjXc1Br4B8N7g==/base.apk!classes20.dex)
     at <app>.core.auth.credentials.GoogleButtonRequestKt.getGoogleBtnOption(GoogleButtonRequest.kt:9)
     ...

From what I can tell from decompiling the obfuscated GetSignInWithGoogleOption class to its Java equivalent, there is no constructor present which takes the DefaultConstructorMarker parameter:

public final class GetSignInWithGoogleOption extends GetCustomCredentialOption {
   // ...
   public GetSignInWithGoogleOption(@NonNull String serverClientId, @Nullable String hostedDomainFilter, @Nullable String nonce) {
      Intrinsics.checkNotNullParameter(serverClientId, "serverClientId");
      // ...
   }

A temporary fix for now is to add the optional hostedDomainFilter = null, argument as well:

val Context.googleBtnOption: GetSignInWithGoogleOption
    get() = GetSignInWithGoogleOption(
        serverClientId = getString(GmsR.string.default_web_client_id),
        hostedDomainFilter = null,
        nonce = UUID.randomUUID().toString()
    )