Status Update
No update yet.
Comments
sg...@google.com
rk...@google.com
Branch: androidx-main
commit c2365dcfeb9064814282304f30f3eb86be71fdc7
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 20 16:33:08 2023
Fix Popup back handling on Android T/13+ when android:enableOnBackInvokedCallback="true"
Bug: 313702338
Bug: 318537200
Test: tested with android:enableOnBackInvokedCallback="true"
Change-Id: I7c7cef686ed9fbfd2d144c90040b13528f1675ed
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
je...@gmail.com
Is there remaining work for this feature request. Support for predictive back in Dialogs would allow Material3 to remove some Dialog forks and would be very helpful!
rk...@google.com
Yeah, we probably want to investigate new API shapes here to take advantage of predictive back. No work ongoing yet though, needs prioritization
sp...@google.com
ro...@google.com
(recapping my chat with Ian)
The tricky part is that the onDismissRequest is really the final signal and a chance for the app to just say 'nope, I don't want the dialog to dismiss' (since they own the state of 'should the dialog be shown or not' simply by either adding the Dialog to composition or leaving out of composition) - that's the just-in-time problem that the comment talks about. It would be very odd to have any kind of progress animation that doesn't actually lead to the dialog being dismissed when it is committed"
so really it needs to be a more holistic look at how to do dialogs and swap from a binary state (shown/not shown) to something that actually has something in between for cases like predictive back
ro...@google.com
Closing since this case is resolved. Additional "emulator too old" bugs can be marked as blocked by 380324147.
rk...@google.com
ro...@google.com
Let's leave this one closed and track the feature request on
Description
Android Studio Version: Unknown
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.3.10-8807927
HAXM / KVM Version: WHPX 10.0.22631
Android SDK Tools: 26.1.1
Host Operating System: Windows 10 Pro
CPU Manufacturer: AMD CPU
Inside a VM
64-bit CPU
RAM: 15663 MB
GPU: GPU #1
Make: 1002
Model: AMD Radeon(TM) Graphics
Device ID: 1638
Build Fingerprint:
AVD Details: Name: 5.4_FWVGA_API_31
CPU/ABI: x86_64
Path: C:\Users\Jeffrey\.android\avd\5.4_FWVGA_API_31.avd
Target: google_apis [Google APIs] (API level 31)
Skin: 480x854
SD Card: 512M
AvdId: 5.4_FWVGA_API_31
PlayStore.enabled: false
avd.ini.displayname: 5.4 FWVGA API 31
avd.ini.encoding: UTF-8
disk.dataPartition.size: 2G
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: no
fastboot.forceFastBoot: yes
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: None
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:a820d4d8990dc5909f5b0b396ccf8f95
hw.device.manufacturer: Generic
hw.gps: yes
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: portrait
hw.keyboard: yes
hw.lcd.density: 160
hw.lcd.height: 854
hw.lcd.width: 480
hw.mainKeys: yes
hw.ramSize: 512
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images\android-31\google_apis\x86_64\
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: no
skin.dynamic: yes
skin.path.backup: _no_skin
tag.display: Google APIs
tag.displaynames: Google APIs
tag.ids: google_apis
vm.heapSize: 48
Steps to Reproduce Bug:freezing with react native expo
Expected Behavior:
Observed Behavior: