Update Compose Graphics to support Wide Color Gamut + HDR [379135036]

Fixed

Bug

Status Update

No update yet.

Description

nj...@google.com

created issue #1

Nov 14, 2024 07:17PM

Currently consumption of Color instances converts the color long to an int via the toArgb API

internal fun NativePaint.setNativeColor(value: Color) {
    this.color = value.toArgb()
}

Instead on supported Android platform levels, we should consume the Color long directly with the following:

internal fun NativePaint.setNativeColor(value: Color) {
    if ((value.value and 0x3fUL) == 0UL || Build.API_LEVEL < 29) {
        this.color = value.toArgb()
    } else {
        this.color = value
    }
}

Comments

ap...@google.com <ap...@google.com> #2Nov 22, 2024 07:23PM

Marked as fixed.

May I ask why P3? This is blocking for me to go to prod, I'd really like some inputs about what is going on so I can either fix or build a repro to have this fixed.

pr...@google.com <pr...@google.com> #3Dec 11, 2024 06:27PM

Unfortunately I am unable to reproduce it as well. Maybe there is a chance you can share your code with me? You can send it to my email as you did previously already.
For the ideas on what to take a look, how do you use LazyListState.layoutInfo in your app? Will it continue growing if you comment out such usages?

to...@gmail.com <to...@gmail.com> #4Jan 7, 2025 07:21AM

It happens even on screens that does not use the layoutInfo it just require many up / down flings.

LazyColumn(state = rememberLazyListState())

The only thing all screen have in common in that they have multiple item {} item{} block :(

Just in case the app is in open beta at https://play.google.com/store/apps/details?id=app.symfonik.music.player but don't think you can see much except repro.

My main question before trying to do complex repro, is how much will it be relevant with all the recent changes in alpha 8 about Lazy stuff? And side question when https://issuetracker.google.com/issues/229752147 is fixed (it touches all my screens maybe another indicator?) will there be some snapshot build with the fix so I can directly try to repro on that?

Issue 379135036

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Nov 22, 2024 07:23PM

pr...@google.com <pr...@google.com> #3Dec 11, 2024 06:27PM

to...@gmail.com <to...@gmail.com> #4Jan 7, 2025 07:21AM

Add comment

Issue metadata