ActivityOptionsCompat missing setTargetDisplayId [379669743]

Fixed

Bug

Status Update

No update yet.

Description

pr...@gmail.com

created issue #1

Nov 18, 2024 09:19PM

Component used: ActivityOptionsCompat
Version used: 1.15
Description

The ActivityOptionsCompat is missing the setTargetDisplayId API which is set on the underlying ActivityOptions. This is needed because ActivityResultLauncher::launch accepts the compat version of "ActivityOptions" instead of a bundle which is accepted by "Context::startActivity()" API.

The android product that I work on deals with displaying content on multiple displays and is not a traditional mobile app, so we have an internal navigation framework to allow displaying content on different displays and having this API exposed natively will allow us to deprecate and remove usages of "startActivityForResult".

Comments

al...@google.com <al...@google.com> #2Nov 18, 2024 09:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

al...@google.com <al...@google.com> #3Nov 18, 2024 09:33PM

Reassigned to bu...@google.com.

We'll close as WontFix if we don't get a response within one week.

Bugjuggler: wait 1 week

bu...@google.com <bu...@google.com> #4Nov 18, 2024 09:33PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2024-11-25 16:33 -0500 EST and then assign the bug to alanv@google.com.

pr...@gmail.com <pr...@gmail.com> #5Nov 18, 2024 11:31PM

I am sorry. The API name is setLaunchDisplayId

https://developer.android.com/reference/android/app/ActivityOptions#setLaunchDisplayId(int)

pr...@gmail.com <pr...@gmail.com> #6Nov 18, 2024 11:33PM

Also, please consider updating the documentation below with the correct API name.

https://source.android.com/docs/core/display/multi_display/activity-launch

bu...@google.com <bu...@google.com> Nov 25, 2024 09:34PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Dec 3, 2024 07:24PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #7Dec 3, 2024 10:10PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Alan Viverette <alanv@google.com>
Link: https://android-review.googlesource.com/3389947

Inline ApiXXImpl methods and unwrap obsolete SDK_INT checks

Expand for full commit details

Inline ApiXXImpl methods and unwrap obsolete SDK_INT checks 
 
Bug: 379669743 
Test: ActivityOptionsCompatTest 
Change-Id: I1e3222908604c1f7a835489ca98a802af0912390

Files:

M core/core/src/main/java/androidx/core/app/ActivityOptionsCompat.java

Hash: b7937b0dfc7ede637b1754a4cb3d4bfe4f71270e
Date: Tue Dec 03 14:47:37 2024

ap...@google.com <ap...@google.com> #8Dec 3, 2024 10:11PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Alan Viverette <alanv@google.com>
Link: https://android-review.googlesource.com/3389948

Add setLaunchDisplayId

Expand for full commit details

Add setLaunchDisplayId 
 
Relnote: Add setLaunchDisplayId to ActivityOptionsCompat 
Test: ActivityOptionsCompatTest 
Fixes: 379669743 
Change-Id: I39e773972f9f91b6f970c542740a61486197a3cc

Files:

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/ActivityOptionsCompat.java
M core/core/src/test/java/androidx/core/app/ActivityOptionsCompatTest.kt

Hash: 317ab2d2ec1439a277dbe9e2212decd86b4431a5
Date: Tue Dec 03 15:26:25 2024

pr...@gmail.com <pr...@gmail.com> #9Dec 4, 2024 08:39AM

Thanks for fixing this. Can you please let me know what version of androidx.core library will contain this change ?

pr...@google.com <pr...@google.com> #10Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core:1.16.0-alpha01