Add OutcomeReceiverCompat to androidx.core.os [380060342]

Assigned

Feature Request

Status Update

No update yet.

Description

pe...@google.com

created issue #1

Nov 20, 2024 04:25PM

See API council conversation here: https://chat.google.com/room/AAAATnZMo34/VJnRMh_50Z8

For Java APIs in AndroidX, there isn't a standard way to deliver an async result that could fail. For Kotlin you'd use a suspend fun (which can throw) and for Java APIs in the platform you'd use an OutcomeReceiver, which was added in API 31.

For context, we (androidx.webkit) are designing an API that would benefit from being able to use OutcomeReceiver and we'd prefer to use a standard approach rather than writing our own.

I assume that androidx.core.os would be the right place for this to live.

Comments

al...@google.com <al...@google.com> #2Nov 20, 2024 05:39PM

Reassigned to pe...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Nov 21, 2024 05:12PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Peter E Conn <peconn@google.com>
Link: https://android-review.googlesource.com/3369779

Add OutcomeReceiverCompat

Expand for full commit details

Add OutcomeReceiverCompat 
 
For use in AndroidX where Android's OutcomeReceiver is not yet available. 
 
Relnote: """Adds OutcomeReceiverCompat, a version of Android's OutcomeReceiver available 
  on all API levels.""" 
 
Bug: 380060342 
Test: presubmit 
Change-Id: Ib82652305f6dd0aab5e9598dbfc13a397ab0f367

Files:

M core/core/api/current.txt
M core/core/api/restricted_current.txt
A core/core/src/main/java/androidx/core/os/OutcomeReceiverCompat.java

Hash: 9f21249882539de0febf492a10656850ddaed65b
Date: Thu Nov 21 14:05:22 2024

pe...@google.com <pe...@google.com> #4Nov 21, 2024 05:17PM

Whats the process for rolling out changes to androidx.core:core?

pe...@google.com <pe...@google.com> #5Nov 21, 2024 05:18PM

+Sayed as he wants to use this for WebView Prefetch API.

el...@google.com <el...@google.com> #6Nov 22, 2024 08:06PM

Thanks Peter!

Based on libraryversions.toml, I don't think that androidx.core:core has a separate module for launch, but it seems to be released with androidx.core group?

al...@google.com <al...@google.com> #7Nov 25, 2024 09:06PM

It's a non-atomic group, so the contained artifacts are versioned (mostly) separately. We version and release the core artifact with core-ktx and core-testing.

Whats the process for rolling out changes to androidx.core:core?

Make the changes, then either request a release on go/jetpad or let me know when you want a release. Generally speaking, core releases whenever contributors (or dependent libraries) need it released. If you need this to go to stable soon, you can file a bug against the core component along the lines of "Release core 1.x.0 to stable" and I'll churn through the process of beta/rc/stable.

pe...@google.com <pe...@google.com> #8Nov 26, 2024 08:26AM

We have some experimental APIs that could do with using this interface. As they're experimental, to not block the library from otherwise progressing through the release train, I assume we need these changes to be in stable?

Filed b/381012242 for releasing to stable.