Add OutcomeReceiverCompat to androidx.core.os [380060342]

Assigned

Feature Request

Status Update

No update yet.

Description

pe...@google.com

created issue #1

Nov 20, 2024 04:25PM

See API council conversation here: https://chat.google.com/room/AAAATnZMo34/VJnRMh_50Z8

For Java APIs in AndroidX, there isn't a standard way to deliver an async result that could fail. For Kotlin you'd use a suspend fun (which can throw) and for Java APIs in the platform you'd use an OutcomeReceiver, which was added in API 31.

For context, we (androidx.webkit) are designing an API that would benefit from being able to use OutcomeReceiver and we'd prefer to use a standard approach rather than writing our own.

I assume that androidx.core.os would be the right place for this to live.

Comments

al...@google.com <al...@google.com> #2Nov 20, 2024 05:39PM

Reassigned to pe...@google.com.

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

ap...@google.com <ap...@google.com> #3Nov 21, 2024 05:12PM

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

pe...@google.com <pe...@google.com> #4Nov 21, 2024 05:17PM

Hi Nona,

Can you please schedule a release after you merge the fix?

pe...@google.com <pe...@google.com> #5Nov 21, 2024 05:18PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020

Adjust the Typeface display style with the style of given font

This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.

Looks like the style argument is ignored on older API implementation.

Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25

A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java

https://android-review.googlesource.com/1318947

el...@google.com <el...@google.com> #6Nov 22, 2024 08:06PM

The following changes were cherrypicked through Coastguard Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6222780589080576/#/history/all) Changes: aosp/1318947

al...@google.com <al...@google.com> #7Nov 25, 2024 09:06PM

Any way I can tell what version this will land in?

pe...@google.com <pe...@google.com> #8Nov 26, 2024 08:26AM

should be in 1.5.0-alpha1 https://developer.android.com/jetpack/androidx/releases/core#1.5.0-alpha01