Verified
Status Update
Comments
ch...@google.com <ch...@google.com>
ta...@google.com <ta...@google.com> #2
We don't really need the id. You can always use -e
as a shorthand for an emulator.
ta...@google.com <ta...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 6fec8f186ae5d1667ea4eb17e697b70ea26539f9
Author: Chris Craik <ccraik@google.com>
Date: Fri Oct 21 14:28:32 2022
Specify device in baseline profile adb pull command
Fixes: 223359380
Test: BaselineProfilesTest
Test: BaselineProfileRuleTest
Relnote: Specify device in baseline profile `adb pull` command
Change-Id: I6ac6c7d2bbd9888dd889b1b790ba21795464f4fa
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/BaselineProfilesTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
https://android-review.googlesource.com/2264199
Branch: androidx-main
commit 6fec8f186ae5d1667ea4eb17e697b70ea26539f9
Author: Chris Craik <ccraik@google.com>
Date: Fri Oct 21 14:28:32 2022
Specify device in baseline profile adb pull command
Fixes: 223359380
Test: BaselineProfilesTest
Test: BaselineProfileRuleTest
Relnote: Specify device in baseline profile `adb pull` command
Change-Id: I6ac6c7d2bbd9888dd889b1b790ba21795464f4fa
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/BaselineProfilesTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
ry...@gmail.com <ry...@gmail.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.2.0-alpha07
ta...@google.com <ta...@google.com>
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Tahsin Masrur <
Link:
Add FlashState to ImageProxy.ImageInfo
Expand for full commit details
Add FlashState to ImageProxy.ImageInfo
This will allow to know whether the flash was fired or not while using the ImageProxy image capture method. Note that the on-disk image capture already had this info through EXIF metadata.
RelNote: "ImageProxy.ImageInfo.getFlashState() added to know whether flash was fired during a capture."
Bug: 380527406
Test: Manual testing through view-test-app
Change-Id: Id2c61f898acee6e75acded80fc41872cd0edf764
Files:
- M
camera/camera-core/api/current.txt
- M
camera/camera-core/api/restricted_current.txt
- M
camera/camera-core/src/androidTest/java/androidx/camera/core/internal/utils/ImageUtilDeviceTest.kt
- M
camera/camera-core/src/main/java/androidx/camera/core/AndroidImageProxy.java
- A
camera/camera-core/src/main/java/androidx/camera/core/FlashState.kt
- M
camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysisAbstractAnalyzer.java
- M
camera/camera-core/src/main/java/androidx/camera/core/ImageInfo.java
- M
camera/camera-core/src/main/java/androidx/camera/core/ImmutableImageInfo.java
- M
camera/camera-core/src/main/java/androidx/camera/core/imagecapture/JpegImage2Result.java
- M
camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureMetaData.java
- M
camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifData.java
- M
camera/camera-core/src/main/java/androidx/camera/core/internal/CameraCaptureResultImageInfo.java
- M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/util/CaptureUtils.kt
Hash: d8889a034b2c2af4ace1f984faa0ef61411042c3
Date: Fri Dec 13 06:50:41 2024
ta...@google.com <ta...@google.com> #6
Hi, this feature has been added and will be available from the next CameraX release. Thanks!
ry...@gmail.com <ry...@gmail.com> #7
Thank you. I'll verify as soon as it's released.
pr...@google.com <pr...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.5.0-alpha05
Description
This is a CameraX Feature Request to provide support to determine if the camera flash unit flash was fired -- primarily when flash mode is set to Auto.
Our current implementation makes use of
CameraController.takePicture()
via theImageCapture.OnImageCapturedCallback()
. Perhaps the flash result can be provided as an additional parameter toonCaptureSuccess(ImageProxy)
The goal is to set the appropriate Exif values for
ExifInterface.TAG_FLASH
. We can determine the flash mode prior to photo capture, but we are unable to determine if the flash fired or not.