Provide support to determine if flash unit was fired during photo capture [380527406]

Verified

Feature Request

Status Update

No update yet.

Description

ry...@gmail.com

created issue #1

Nov 24, 2024 06:41PM

This is a CameraX Feature Request to provide support to determine if the camera flash unit flash was fired -- primarily when flash mode is set to Auto.

Our current implementation makes use of CameraController.takePicture() via the ImageCapture.OnImageCapturedCallback(). Perhaps the flash result can be provided as an additional parameter to onCaptureSuccess(ImageProxy)

The goal is to set the appropriate Exif values for ExifInterface.TAG_FLASH. We can determine the flash mode prior to photo capture, but we are unable to determine if the flash fired or not.

Comments

ch...@google.com <ch...@google.com> Nov 25, 2024 01:31AM

Reassigned to ta...@google.com.

ta...@google.com <ta...@google.com> #2Nov 26, 2024 08:20AM

The basic issue is that QualitySelector doesn't have any public method to get the selected/chosen quality as an Int (or any other raw type like String) that would correspond to a (publicly defined) constant.

Message last modified on Nov 26, 2024 08:21AM

ta...@google.com <ta...@google.com> #3Nov 26, 2024 08:24AM

Project: platform/frameworks/support
Branch: androidx-main
Author: leo huang <leohuang@google.com>
Link: https://android-review.googlesource.com/3426130

Add VideoCapture.getSelectedQuality() API

Expand for full commit details

Add VideoCapture.getSelectedQuality() API 
 
 This API allows retrieving the selected Quality for a VideoCapture instance based on the provided QualitySelector. 
 
 The getSelectedQuality() method returns a value only when the VideoCapture is bound to a lifecycle. 
 
 This API was requested by both JCA and 3rd-party developers. 
 
Relnote: "Add VideoCapture.getSelectedQuality() to know the selected Quality based on the QualitySelector." 
 
Bug: 204288986 
Test: VideoCaptureTest 
Change-Id: I7050868dea1f1654386c991d441c25af2e3f1fe4

Files:

M camera/camera-core/src/main/java/androidx/camera/core/impl/StreamSpec.java
A camera/camera-core/src/main/java/androidx/camera/core/streamsharing/PreferredChildSize.kt
M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/ResolutionsMerger.java
M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/StreamSharing.java
M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/VirtualCameraAdapter.java
M camera/camera-core/src/test/java/androidx/camera/core/streamsharing/ResolutionsMergerTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/streamsharing/VirtualCameraAdapterTest.kt
M camera/camera-video/api/current.txt
M camera/camera-video/api/restricted_current.txt
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

Hash: f24822959fa0cc4dc6b1c5400b1d4ab46fb2c18b
Date: Mon Dec 23 15:29:59 2024

ry...@gmail.com <ry...@gmail.com> #4Nov 26, 2024 05:14PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.5.0-alpha05
androidx.camera:camera-video:1.5.0-alpha05

ta...@google.com <ta...@google.com> Dec 23, 2024 07:09AM

Accepted by ta...@google.com.

ap...@google.com <ap...@google.com> #5Dec 23, 2024 07:15AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Tahsin Masrur <tahsinm@google.com>
Link: https://android-review.googlesource.com/3412317

Add FlashState to ImageProxy.ImageInfo

Expand for full commit details

Add FlashState to ImageProxy.ImageInfo 
 
  This will allow to know whether the flash was fired or not while using the ImageProxy image capture method. Note that the on-disk image capture already had this info through EXIF metadata. 
 
RelNote: "ImageProxy.ImageInfo.getFlashState() added to know whether flash was fired during a capture." 
 
Bug: 380527406 
Test: Manual testing through view-test-app 
Change-Id: Id2c61f898acee6e75acded80fc41872cd0edf764

Files:

M camera/camera-core/api/current.txt
M camera/camera-core/api/restricted_current.txt
M camera/camera-core/src/androidTest/java/androidx/camera/core/internal/utils/ImageUtilDeviceTest.kt
M camera/camera-core/src/main/java/androidx/camera/core/AndroidImageProxy.java
A camera/camera-core/src/main/java/androidx/camera/core/FlashState.kt
M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysisAbstractAnalyzer.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/ImmutableImageInfo.java
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/JpegImage2Result.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureMetaData.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifData.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/CameraCaptureResultImageInfo.java
M camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/util/CaptureUtils.kt

Hash: d8889a034b2c2af4ace1f984faa0ef61411042c3
Date: Fri Dec 13 06:50:41 2024

ta...@google.com <ta...@google.com> #6Dec 23, 2024 07:16AM

Verified by ta...@google.com.

Hi, this feature has been added and will be available from the next CameraX release. Thanks!

ry...@gmail.com <ry...@gmail.com> #7Dec 24, 2024 01:17AM

Thank you. I'll verify as soon as it's released.

pr...@google.com <pr...@google.com> #8Jan 15, 2025 06:30PM