Status Update
No update yet.
Comments
ch...@google.com
ta...@google.com
Hi,
Thanks for filing the issue. We can probably add this information to the
ta...@google.com
By the way, note that this info is already added to the Exif values of saved image if you are using the ImageCapture.OnImageCapturedCallback. So, if your app requirements don't have any explicit need of OnImageCapturedCallback, that is also an option.
ry...@gmail.com
Thanks for looking into this. Using ImageProxy or ImageInfo to pass the value seems like a great idea.
I did suspect that ImageCapture.OnImageSavedCallback would have this set, but we have an explicit need for ImageCapture.OnImageCapturedCallback.
ta...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Tahsin Masrur <
Link:
Add FlashState to ImageProxy.ImageInfo
Expand for full commit details
Add FlashState to ImageProxy.ImageInfo
This will allow to know whether the flash was fired or not while using the ImageProxy image capture method. Note that the on-disk image capture already had this info through EXIF metadata.
RelNote: "ImageProxy.ImageInfo.getFlashState() added to know whether flash was fired during a capture."
Bug: 380527406
Test: Manual testing through view-test-app
Change-Id: Id2c61f898acee6e75acded80fc41872cd0edf764
Files:
- M
camera/camera-core/api/current.txt - M
camera/camera-core/api/restricted_current.txt - M
camera/camera-core/src/androidTest/java/androidx/camera/core/internal/utils/ImageUtilDeviceTest.kt - M
camera/camera-core/src/main/java/androidx/camera/core/AndroidImageProxy.java - A
camera/camera-core/src/main/java/androidx/camera/core/FlashState.kt - M
camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysisAbstractAnalyzer.java - M
camera/camera-core/src/main/java/androidx/camera/core/ImageInfo.java - M
camera/camera-core/src/main/java/androidx/camera/core/ImmutableImageInfo.java - M
camera/camera-core/src/main/java/androidx/camera/core/imagecapture/JpegImage2Result.java - M
camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureMetaData.java - M
camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ExifData.java - M
camera/camera-core/src/main/java/androidx/camera/core/internal/CameraCaptureResultImageInfo.java - M
camera/integration-tests/viewtestapp/src/main/java/androidx/camera/integration/view/util/CaptureUtils.kt
Hash: d8889a034b2c2af4ace1f984faa0ef61411042c3
Date: Fri Dec 13 06:50:41 2024
ta...@google.com
Hi, this feature has been added and will be available from the next CameraX release. Thanks!
ry...@gmail.com
Thank you. I'll verify as soon as it's released.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.5.0-alpha05
Description
This is a CameraX Feature Request to provide support to determine if the camera flash unit flash was fired -- primarily when flash mode is set to Auto.
Our current implementation makes use of
CameraController.takePicture()via theImageCapture.OnImageCapturedCallback(). Perhaps the flash result can be provided as an additional parameter toonCaptureSuccess(ImageProxy)The goal is to set the appropriate Exif values for
ExifInterface.TAG_FLASH. We can determine the flash mode prior to photo capture, but we are unable to determine if the flash fired or not.