SecureTextField Active indicator does not get clipped with Modifier.clip [380704151]

Fixed

Bug

Status Update

No update yet.

Description

cl...@gmail.com

created issue #1

Nov 25, 2024 06:23AM

Description has been deleted.

deleted

0 B

deleted

0 B

Comments

cl...@gmail.com <cl...@gmail.com> #2Nov 25, 2024 07:18AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

bug.png

8.7 KB

View

Download

intended.png

4.7 KB

View

Download

ma...@google.com <ma...@google.com> Dec 2, 2024 04:56PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Dec 2, 2024 05:02PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3Dec 3, 2024 08:21PM

Project: platform/frameworks/support-golden
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3387659

Add scubas for text field indicator line clipping

Expand for full commit details

Add scubas for text field indicator line clipping 
 
Bug: b/380704151 
Change-Id: I4543104243f0598a7568c12da678dd3db1e0999d

Files:

A compose/material/material/textField_indicatorLine_clippedToShape_emulator.png
A compose/material3/material3/textField_indicatorLine_clippedToShape_emulator.png

Hash: 27986e61214177960442c511c3545c9a9ba61267
Date: Mon Dec 02 16:53:23 2024

ap...@google.com <ap...@google.com> #4Dec 3, 2024 08:21PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3387263

Clip filled text field indicator line to shape

Expand for full commit details

Clip filled text field indicator line to shape 
 
Bug: b/380704151 
Test: added screenshot tests 
Relnote: "Fixed issue where filled text fields with custom shape didn't clip the indicator line." 
Change-Id: I4f87f4637da0f17e9e435fa5609061fd320b7f7b

Files:

M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldScreenshotTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SecureTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextFieldScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldDefaults.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/autofill/TextFieldsSemanticAutofillTest.kt

Hash: ad2e4590297945ce8a097f963d0580912276a3f5
Date: Mon Dec 02 19:22:10 2024

ma...@google.com <ma...@google.com> #5Dec 3, 2024 09:06PM

Marked as fixed.

The fix has been submitted and will be available in an upcoming release. Now the component will handle this clipping automatically so you do not need to add your own Modifier.clip.

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.8.0-alpha07
androidx.compose.material:material-android:1.8.0-alpha07
androidx.compose.material:material-jvmstubs:1.8.0-alpha07
androidx.compose.material:material-linuxx64stubs:1.8.0-alpha07
androidx.compose.ui:ui:1.8.0-alpha07
androidx.compose.ui:ui-android:1.8.0-alpha07
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha07
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha07

ap...@google.com <ap...@google.com> #7Dec 11, 2024 07:25PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3400559

Clip indicator line to text field shape

Expand for full commit details

Clip indicator line to text field shape 
 
Another approach, replacing aosp/3387263. 
Now, only the indicator line is clipped instead 
of the entire text field. 
 
Bug: b/380704151 
Test: added screenshot tests 
Relnote: "`Modifier.indicatorLine` now takes a shape for the text field to handle clipping." 
Change-Id: I8c5f31cc77134107ae7895a273895f71ee6b2cc6

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextFieldScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextField.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldDefaults.kt

Hash: de96373ca0f3f3bdc29c7b9aaeb98ac449eca1b4
Date: Mon Dec 09 22:18:43 2024

pr...@google.com <pr...@google.com> #8Jan 15, 2025 06:31PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha06
androidx.compose.material3:material3-android:1.4.0-alpha06
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha06
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha06

Issue 380704151

Description

Issue summary

Comments

cl...@gmail.com <cl...@gmail.com> #2Nov 25, 2024 07:18AM

ma...@google.com <ma...@google.com> Dec 2, 2024 04:56PM

ma...@google.com <ma...@google.com> Dec 2, 2024 05:02PM

ap...@google.com <ap...@google.com> #3Dec 3, 2024 08:21PM

ap...@google.com <ap...@google.com> #4Dec 3, 2024 08:21PM

ma...@google.com <ma...@google.com> #5Dec 3, 2024 09:06PM

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

ap...@google.com <ap...@google.com> #7Dec 11, 2024 07:25PM

pr...@google.com <pr...@google.com> #8Jan 15, 2025 06:31PM

Add comment

Issue metadata